You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2007/10/19 14:05:31 UTC
svn commit: r586391 - in
/jakarta/jmeter/trunk/src/core/org/apache/jmeter/testelement:
AbstractTestElement.java TestElement.java TestPlan.java
Author: sebb
Date: Fri Oct 19 05:05:31 2007
New Revision: 586391
URL: http://svn.apache.org/viewvc?rev=586391&view=rev
Log:
Move COMMENTS to TestElement; implment getComment()/setComment()
Modified:
jakarta/jmeter/trunk/src/core/org/apache/jmeter/testelement/AbstractTestElement.java
jakarta/jmeter/trunk/src/core/org/apache/jmeter/testelement/TestElement.java
jakarta/jmeter/trunk/src/core/org/apache/jmeter/testelement/TestPlan.java
Modified: jakarta/jmeter/trunk/src/core/org/apache/jmeter/testelement/AbstractTestElement.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/core/org/apache/jmeter/testelement/AbstractTestElement.java?rev=586391&r1=586390&r2=586391&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/core/org/apache/jmeter/testelement/AbstractTestElement.java (original)
+++ jakarta/jmeter/trunk/src/core/org/apache/jmeter/testelement/AbstractTestElement.java Fri Oct 19 05:05:31 2007
@@ -124,6 +124,14 @@
return getProperty(TestElement.NAME).getStringValue();
}
+ public void setComment(String comment){
+ setProperty(new StringProperty(TestElement.COMMENTS, comment));
+ }
+
+ public String getComment(){
+ return getProperty(TestElement.COMMENTS).getStringValue();
+ }
+
/**
* Get the named property. If it doesn't exist, a new NullProperty object is
* created with the same name and returned.
Modified: jakarta/jmeter/trunk/src/core/org/apache/jmeter/testelement/TestElement.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/core/org/apache/jmeter/testelement/TestElement.java?rev=586391&r1=586390&r2=586391&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/core/org/apache/jmeter/testelement/TestElement.java (original)
+++ jakarta/jmeter/trunk/src/core/org/apache/jmeter/testelement/TestElement.java Fri Oct 19 05:05:31 2007
@@ -23,13 +23,18 @@
import org.apache.jmeter.threads.JMeterContext;
public interface TestElement extends Cloneable {
- public final static String NAME = "TestElement.name";
+ public final static String NAME = "TestElement.name"; //$NON-NLS-1$
- public final static String GUI_CLASS = "TestElement.gui_class";
+ public final static String GUI_CLASS = "TestElement.gui_class"; //$NON-NLS-1$
- public final static String ENABLED = "TestElement.enabled";
+ public final static String ENABLED = "TestElement.enabled"; //$NON-NLS-1$
- public final static String TEST_CLASS = "TestElement.test_class";
+ public final static String TEST_CLASS = "TestElement.test_class"; //$NON-NLS-1$
+
+ // Needed by AbstractTestElement.
+ // Also TestElementConverter and TestElementPropertyConverter for handling empty comments
+ public final static String COMMENTS = "TestPlan.comments"; //$NON-NLS-1$
+ // N.B. Comments originally only applied to Test Plans, hence the name - which can now not be easily changed
public void addTestElement(TestElement child);
@@ -173,4 +178,8 @@
public String getName();
public void setName(String name);
+
+ public String getComment();
+
+ public void setComment(String comment);
}
Modified: jakarta/jmeter/trunk/src/core/org/apache/jmeter/testelement/TestPlan.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/core/org/apache/jmeter/testelement/TestPlan.java?rev=586391&r1=586390&r2=586391&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/core/org/apache/jmeter/testelement/TestPlan.java (original)
+++ jakarta/jmeter/trunk/src/core/org/apache/jmeter/testelement/TestPlan.java Fri Oct 19 05:05:31 2007
@@ -55,8 +55,6 @@
public final static String CLASSPATHS = "TestPlan.user_define_classpath"; //$NON-NLS-1$
private static final String CLASSPATH_SEPARATOR = ","; //$NON-NLS-1$
- public final static String COMMENTS = "TestPlan.comments"; //$NON-NLS-1$
-
// Does not appear to be needed
public final static String BASEDIR = "basedir";
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org