You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/11/25 07:28:56 UTC
[GitHub] [camel] vladimirfx opened a new pull request #6475: CAMEL-17232: Revert "Camel-AWS2-S3: When includeBody is false
vladimirfx opened a new pull request #6475:
URL: https://github.com/apache/camel/pull/6475
This reverts commit ad296097c48558ffdf938fd8646bbeb6e7fd6320.
<!-- Uncomment and fill this section if your PR is not trivial
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] vladimirfx commented on pull request #6475: CAMEL-17232: Revert "Camel-AWS2-S3: When includeBody is false
Posted by GitBox <gi...@apache.org>.
vladimirfx commented on pull request #6475:
URL: https://github.com/apache/camel/pull/6475#issuecomment-978915879
> I'm sorry, it was my fault
It is absolutely understandable considering property name `includeBody`. Maybe name it something like downloadBody or similar? Current name is very annoying...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #6475: CAMEL-17232: Revert "Camel-AWS2-S3: When includeBody is false
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #6475:
URL: https://github.com/apache/camel/pull/6475#issuecomment-978913308
I'm sorry, it was my fault
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] vladimirfx commented on pull request #6475: CAMEL-17232: Revert "Camel-AWS2-S3: When includeBody is false
Posted by GitBox <gi...@apache.org>.
vladimirfx commented on pull request #6475:
URL: https://github.com/apache/camel/pull/6475#issuecomment-978912090
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd merged pull request #6475: CAMEL-17232: Revert "Camel-AWS2-S3: When includeBody is false
Posted by GitBox <gi...@apache.org>.
oscerd merged pull request #6475:
URL: https://github.com/apache/camel/pull/6475
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org