[PR] [FLINK-40144]Avoid query database when only get table column [flink-connector-jdbc]

["Mrart (via GitHub)" <gi...@apache.org>]

Mrart opened a new pull request, #211:
URL: https://github.com/apache/flink-connector-jdbc/pull/211

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-40144]Avoid query database when only get table column [flink-connector-jdbc]

["MartijnVisser (via GitHub)" <gi...@apache.org>]

MartijnVisser commented on code in PR #211:
URL: https://github.com/apache/flink-connector-jdbc/pull/211#discussion_r4081217724


##########
flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/database/catalog/AbstractJdbcCatalog.java:
##########
@@ -292,7 +292,7 @@ public CatalogBaseTable getTable(ObjectPath tablePath)
 
             PreparedStatement ps =
                     conn.prepareStatement(
-                            String.format("SELECT * FROM %s;", getSchemaTableName(tablePath)));
+                            String.format("SELECT * FROM %s where 0=1;", getSchemaTableName(tablePath)));

Review Comment:
   This line fails `spotless:check`, so you'll need to run `mvn spotless:apply`. Could you also write `WHERE` in upper case like the rest of the statement?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org