You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/10/25 00:12:11 UTC
[GitHub] [lucene] dsmiley opened a new pull request #411: LUCENE-10202: spatial: feature-variants
dsmiley opened a new pull request #411:
URL: https://github.com/apache/lucene/pull/411
https://issues.apache.org/jira/browse/LUCENE-10202
TODO on choice of naming RE spherical vs spatial3d
Note: as of this writing, the build doesn't publish the nice Gradle metadata
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #411: LUCENE-10202: spatial: feature-variants
Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #411:
URL: https://github.com/apache/lucene/pull/411#issuecomment-951573527
I didn't want to discourage you from trying - maybe the solution is simple, somewhere. I just recall spending a few hours trying to figure out how to make the POMs sane on another project and couldn't do it - turning off gradle metadata was the only way to get the poms right (which I care more than the metadata).
You could try to add those optional blocks by modifying the pom right before it's written. It's hacky but it can be done.
https://github.com/apache/lucene/blob/main/gradle/maven/publications-maven.gradle#L65-L75
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dsmiley commented on pull request #411: LUCENE-10202: spatial: feature-variants
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #411:
URL: https://github.com/apache/lucene/pull/411#issuecomment-950427225
I spot-checked the generated Maven POMs locally. As expected and according to the Gradle docs, these dependencies showed as optional.
I see something weird though -- this dependency:
```
<dependency>
<groupId>org.apache</groupId>
<artifactId>lucene-root</artifactId>
<version>9.0.0-SNAPSHOT</version>
<scope>compile</scope>
<optional>true</optional>
</dependency>
```
This weird lucene-root dependency is only here; it isn't in any of the other Lucene modules. I confirmed this only appears here because of the use of this Gradle feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dsmiley commented on pull request #411: LUCENE-10202: spatial: feature-variants
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #411:
URL: https://github.com/apache/lucene/pull/411#issuecomment-951533639
Bummer ok. I'll leave this here; not sure if/when I'll get back to it. Sadly the Gradle docs describe no other way to emit your dependencies as optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #411: LUCENE-10202: spatial: feature-variants
Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #411:
URL: https://github.com/apache/lucene/pull/411#issuecomment-950586805
> This weird lucene-root dependency is only here; it isn't in any of the other Lucene modules. I confirmed this only appears here because of the use of this Gradle feature.
Things like this is exactly what prevented me from using metadata. If you have a dependency on such a weird-looking artifact and it's not published anywhere, things break (even if it's optional).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #411: LUCENE-10202: spatial: feature-variants
Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #411:
URL: https://github.com/apache/lucene/pull/411#issuecomment-950587825
So, in other words - the POMs have to be right. If enabling metadata means we have odd entries in POMs, I'm -1 for adding metadata. The lucene-root dependency may be a result of how palantir works internally too - I'm really not sure and I can't devote any time to look into this (I did in the past, without success).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org