[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4288: Use `eclipse-temurin:8-jdk-focal` as default base image

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #4288:
URL: https://github.com/apache/kyuubi/pull/4288#discussion_r1101362404


##########
build/Dockerfile:
##########
@@ -29,9 +29,9 @@
 
 # Declare the BASE_IMAGE argument in the first line, for more detail
 # see: https://github.com/moby/moby/issues/38379
-ARG BASE_IMAGE=openjdk:8-jdk
+ARG BASE_IMAGE=eclipse-temurin:8-jdk-focal
 
-FROM maven:3.6-jdk-8 as builder
+FROM eclipse-temurin:8-jdk-focal as builder

Review Comment:
   it's hard to maintain the maven version in multi places, so it's better to use `build/mvn` to auto-download the expected version.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org