[jira] [Commented] (FLINK-10607) Unify to remove duplicated NoOpResultPartitionConsumableNotifier

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16658662#comment-16658662 ] 

ASF GitHub Bot commented on FLINK-10607:
----------------------------------------

zhijiangW opened a new pull request #6892: [FLINK-10607][network][test] Unify to remove duplicated NoOpResultPartitionConsumableNotifier
URL: https://github.com/apache/flink/pull/6892
 
 
   ## What is the purpose of the change
   
   *There are currently existing two same `NoOpResultPartitionConsumableNotifier`. We should retain only one and unify all the usages in related tests for avoiding mock.*
   
   ## Brief change log
   
     - *Keep only one `NoOpResultPartitionConsumableNotifier` for tests*
     - *Modify all the related tests to avoid mock `ResultPartitionConsumableNotifier`*
   
   ## Verifying this change
   
   *This change is already covered by existing tests.*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Unify to remove duplicated NoOpResultPartitionConsumableNotifier
> ----------------------------------------------------------------
>
>                 Key: FLINK-10607
>                 URL: https://issues.apache.org/jira/browse/FLINK-10607
>             Project: Flink
>          Issue Type: Test
>          Components: Network, Tests
>    Affects Versions: 1.6.1, 1.7.0
>            Reporter: zhijiang
>            Assignee: zhijiang
>            Priority: Minor
>              Labels: pull-request-available
>
> Currently there exists two same {{NoOpResultPartitionConsumableNotifier}} implementations for different tests. We can deduplicate the common codes and public it for unified usages. And it will also bring benefits for future new tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)