[GitHub] [airflow] sfc-gh-madkins commented on pull request #16420: Added ability for Snowflake to attribute usage to Airflow by adding an application parameter

[GitBox <gi...@apache.org>]

sfc-gh-madkins commented on pull request #16420:
URL: https://github.com/apache/airflow/pull/16420#issuecomment-860738211


   Go discussion on whether this should be a user-defined parameter that could
   be over-written.
   
   The idea was for managed airflow providers (Astronomer, AWS), they could
   override this parameter for their installations of this repo. I guess they
   could override an non user-defined parameter as well.
   
   Any thoughts? I can talk to Ry over at Astronomer on this.
   
   On Mon, Jun 14, 2021 at 9:32 AM Kaxil Naik ***@***.***> wrote:
   
   > ***@***.**** commented on this pull request.
   > ------------------------------
   >
   > In airflow/providers/snowflake/hooks/snowflake.py
   > <https://github.com/apache/airflow/pull/16420#discussion_r651001979>:
   >
   > > @@ -143,6 +143,7 @@ def __init__(self, *args, **kwargs) -> None:
   >
   >          self.schema = kwargs.pop("schema", None)
   >
   >          self.authenticator = kwargs.pop("authenticator", None)
   >
   >          self.session_parameters = kwargs.pop("session_parameters", None)
   >
   > +        self.application = kwargs.pop("application")
   >
   >
   > ⬇️ Suggested change
   >
   > -        self.application = kwargs.pop("application")
   >
   > +        self.application = kwargs.pop("application", None)
   >
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/airflow/pull/16420#pullrequestreview-682988164>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/ATSRCUZ5DT2YGSVVNFXNO6LTSYHGJANCNFSM46TNNUEQ>
   > .
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org