You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2019/12/13 08:31:00 UTC
[native-toolchain-CR] IMPALA-9246 Add patch for crcutils to support aarch64
huangtianhua223@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14901
Change subject: IMPALA-9246 Add patch for crcutils to support aarch64
......................................................................
IMPALA-9246 Add patch for crcutils to support aarch64
This adds a patch for crcutils to make it works on
aarch64 platform.
Change-Id: Ia3c38563a549ab9c522e23a19e9951f5ab0ada37
---
M buildall.sh
A source/crcutil/crcutil-440ba7babeff77ffad992df3a10c767f184e946e-patches/0002-Build-crcutil-440ba7b-on-aarch64.patch
2 files changed, 123 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/01/14901/1
--
To view, visit http://gerrit.cloudera.org:8080/14901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3c38563a549ab9c522e23a19e9951f5ab0ada37
Gerrit-Change-Number: 14901
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
[native-toolchain-CR] IMPALA-9246 Add patch for crcutils to support aarch64
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14901 )
Change subject: IMPALA-9246 Add patch for crcutils to support aarch64
......................................................................
Patch Set 4: Code-Review+2
I'm going to do a build to confirm it builds on all platforms.
--
To view, visit http://gerrit.cloudera.org:8080/14901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3c38563a549ab9c522e23a19e9951f5ab0ada37
Gerrit-Change-Number: 14901
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Dec 2019 21:12:47 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-9246 Add patch for crcutils to support aarch64
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
huangtianhua223@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/14901 )
Change subject: IMPALA-9246 Add patch for crcutils to support aarch64
......................................................................
Patch Set 2:
@Tim Armstrong, thanks for reviewing these.
Yes, https://gerrit.cloudera.org/#/c/14873/ proposed by my classmate, we are now working on building impala/kudu on aarch64 platform.
It's greate if the owner of crcutils to add this patch to support aarch64 platform :)
--
To view, visit http://gerrit.cloudera.org:8080/14901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3c38563a549ab9c522e23a19e9951f5ab0ada37
Gerrit-Change-Number: 14901
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Dec 2019 01:30:29 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-9246 Add patch for crcutils to support aarch64
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14901 )
Change subject: IMPALA-9246 Add patch for crcutils to support aarch64
......................................................................
Patch Set 2:
I'm trying to figure out if we should contribute these patches upstream somewhere. Looks like the original commit is present in this repo - https://github.com/adembo/crcutil. I reached out to the owner to check if that is still maintained. If so we should contribute the code changes to that repo.
--
To view, visit http://gerrit.cloudera.org:8080/14901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3c38563a549ab9c522e23a19e9951f5ab0ada37
Gerrit-Change-Number: 14901
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Dec 2019 17:14:00 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-9246 Add patch for crcutils to support aarch64
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14901 )
Change subject: IMPALA-9246 Add patch for crcutils to support aarch64
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14901/2/buildall.sh
File buildall.sh:
http://gerrit.cloudera.org:8080/#/c/14901/2/buildall.sh@124
PS2, Line 124: CRCUTIL_VERSION=440ba7babeff77ffad992df3a10c767f184e946e-p2\
Please bump the version for all architectures, we don't need to diverge them.
--
To view, visit http://gerrit.cloudera.org:8080/14901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3c38563a549ab9c522e23a19e9951f5ab0ada37
Gerrit-Change-Number: 14901
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Dec 2019 18:34:03 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-9246 Add patch for crcutils to support aarch64
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14901 )
Change subject: IMPALA-9246 Add patch for crcutils to support aarch64
......................................................................
Patch Set 2:
FWIW this is the same patch as https://gerrit.cloudera.org/#/c/14873/ (Adar pointed me to it).
--
To view, visit http://gerrit.cloudera.org:8080/14901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3c38563a549ab9c522e23a19e9951f5ab0ada37
Gerrit-Change-Number: 14901
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Dec 2019 18:32:51 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-9246 Add patch for crcutils to support aarch64
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14901 )
Change subject: IMPALA-9246 Add patch for crcutils to support aarch64
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3c38563a549ab9c522e23a19e9951f5ab0ada37
Gerrit-Change-Number: 14901
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Dec 2019 23:39:59 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-9246 Add patch for crcutils to support aarch64
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14901
to look at the new patch set (#4).
Change subject: IMPALA-9246 Add patch for crcutils to support aarch64
......................................................................
IMPALA-9246 Add patch for crcutils to support aarch64
This adds a patch for crcutils to make it works on
aarch64 platform.
Change-Id: Ia3c38563a549ab9c522e23a19e9951f5ab0ada37
---
M buildall.sh
A source/crcutil/crcutil-440ba7babeff77ffad992df3a10c767f184e946e-patches/0002-Build-crcutil-440ba7b-on-aarch64.patch
2 files changed, 119 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/01/14901/4
--
To view, visit http://gerrit.cloudera.org:8080/14901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3c38563a549ab9c522e23a19e9951f5ab0ada37
Gerrit-Change-Number: 14901
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[native-toolchain-CR] IMPALA-9246 Add patch for crcutils to support aarch64
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14901 )
Change subject: IMPALA-9246 Add patch for crcutils to support aarch64
......................................................................
IMPALA-9246 Add patch for crcutils to support aarch64
This adds a patch for crcutils to make it works on
aarch64 platform.
Change-Id: Ia3c38563a549ab9c522e23a19e9951f5ab0ada37
Reviewed-on: http://gerrit.cloudera.org:8080/14901
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Tim Armstrong <ta...@cloudera.com>
---
M buildall.sh
A source/crcutil/crcutil-440ba7babeff77ffad992df3a10c767f184e946e-patches/0002-Build-crcutil-440ba7b-on-aarch64.patch
2 files changed, 119 insertions(+), 1 deletion(-)
Approvals:
Tim Armstrong: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3c38563a549ab9c522e23a19e9951f5ab0ada37
Gerrit-Change-Number: 14901
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[native-toolchain-CR] IMPALA-9246 Add patch for crcutils to support aarch64
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
huangtianhua223@gmail.com has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/14901 )
Change subject: IMPALA-9246 Add patch for crcutils to support aarch64
......................................................................
IMPALA-9246 Add patch for crcutils to support aarch64
This adds a patch for crcutils to make it works on
aarch64 platform.
Change-Id: Ia3c38563a549ab9c522e23a19e9951f5ab0ada37
---
M buildall.sh
A source/crcutil/crcutil-440ba7babeff77ffad992df3a10c767f184e946e-patches/0002-Build-crcutil-440ba7b-on-aarch64.patch
2 files changed, 123 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/01/14901/2
--
To view, visit http://gerrit.cloudera.org:8080/14901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3c38563a549ab9c522e23a19e9951f5ab0ada37
Gerrit-Change-Number: 14901
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>