You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "tmchow (via GitHub)" <gi...@apache.org> on 2026/04/16 14:35:59 UTC
[PR] style: fix low-risk comment typos and duplicated words [pinot]
tmchow opened a new pull request, #18236:
URL: https://github.com/apache/pinot/pull/18236
## Summary
Per #18226, sweep a few low-risk comment and Javadoc typos across existing Java files. Comments only -- no code changes, no parameter-name renames, no behavior change.
## What changed
- `RefreshSegmentTaskExecutor` — `explicity` → `explicitly` (the file called out in the issue body).
- `DoubleGroupByResultHolderTest`, `MemoryEstimator`, `QueryInvertedSortedIndexRecommender`, `BaseOffHeapMutableDictionary`, `ComplexTypeTransformer` — duplicated `the the` reduced to `the`.
- `RealtimeToOfflineSegmentsTaskMetadata` — `Verify that is is running` → `Verify that it is running`.
- `BlockingSegmentCompletionFSM` — `An FSM is is created` → `An FSM is created`.
## Scope note
I deliberately left parameter-name typos (for example `occurence` on the `RegexpReplaceVar` scalar functions) out of this PR. Those appear in public-facing Javadoc (`@param occurence`) tied to the parameter names themselves, so renaming them could be confused with an API change even though the parameter names do not affect the SQL function signature. Happy to do a follow-up PR for those once you confirm the direction.
Refs #18226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] style: fix low-risk comment typos and duplicated words [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18236:
URL: https://github.com/apache/pinot/pull/18236#issuecomment-4262625489
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/18236?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 55.28%. Comparing base ([`b989795`](https://app.codecov.io/gh/apache/pinot/commit/b9897956e6c586eb6530102ccf82ec776c18bce3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9469a6c`](https://app.codecov.io/gh/apache/pinot/commit/9469a6c57dec61bcdd1f9c7a39bd61aeaebe42a9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (b989795) and HEAD (9469a6c). Click for more details.
>
> <details><summary>HEAD has 36 uploads less than BASE</summary>
>
>| Flag | BASE (b989795) | HEAD (9469a6c) |
>|------|------|------|
>|java-21|5|1|
>|unittests1|2|1|
>|unittests|4|1|
>|temurin|10|1|
>|java-11|5|0|
>|unittests2|2|0|
>|integration|6|0|
>|integration1|2|0|
>|integration2|2|0|
>|custom-integration1|2|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18236 +/- ##
============================================
- Coverage 63.41% 55.28% -8.13%
+ Complexity 1627 837 -790
============================================
Files 3243 2548 -695
Lines 197040 145989 -51051
Branches 30466 23471 -6995
============================================
- Hits 124944 80715 -44229
+ Misses 62093 58315 -3778
+ Partials 10003 6959 -3044
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/18236/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/18236/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration](https://app.codecov.io/gh/apache/pinot/pull/18236/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/18236/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/18236/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-11](https://app.codecov.io/gh/apache/pinot/pull/18236/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-21](https://app.codecov.io/gh/apache/pinot/pull/18236/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.28% <ø> (-8.10%)` | :arrow_down: |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/18236/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.28% <ø> (-8.13%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/18236/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.28% <ø> (-8.12%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/18236/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.28% <ø> (-0.06%)` | :arrow_down: |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/18236/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/18236?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] style: fix low-risk comment typos and duplicated words [pinot]
Posted by "yashmayya (via GitHub)" <gi...@apache.org>.
yashmayya merged PR #18236:
URL: https://github.com/apache/pinot/pull/18236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org