You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@teaclave.apache.org by Mingshen Sun <no...@github.com> on 2020/08/06 00:54:26 UTC
[apache/incubator-teaclave] Use byte array instead of base64 for
image transfer making parsing faster (#402)
## Description
- Use byte array instead of base64
You can view, comment on, or merge this pull request online at:
https://github.com/apache/incubator-teaclave/pull/402
-- Commit Summary --
* Use byte array instead of base64 for image transfer making parsing faster
-- File Changes --
M examples/python/builtin_face_detection.py (11)
M function/src/face_detection.rs (12)
-- Patch Links --
https://github.com/apache/incubator-teaclave/pull/402.patch
https://github.com/apache/incubator-teaclave/pull/402.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/402
Re: [apache/incubator-teaclave] Use byte array instead of base64 for
image transfer making parsing faster (#402)
Posted by Mingshen Sun <no...@github.com>.
Merged #402 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/402#event-3634654107
Re: [apache/incubator-teaclave] Use byte array instead of base64 for
image transfer making parsing faster (#402)
Posted by yc-huang <no...@github.com>.
I see, this is not for optimizing the on wire transfering size, but for optimizing the json decoding cost (e.g. memory comsumption...)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/402#issuecomment-670302631
Re: [apache/incubator-teaclave] Use byte array instead of base64 for
image transfer making parsing faster (#402)
Posted by yc-huang <no...@github.com>.
Do we need to tune the code of try_from implementation?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/402#issuecomment-669680296
Re: [apache/incubator-teaclave] Use byte array instead of base64 for
image transfer making parsing faster (#402)
Posted by Mingshen Sun <no...@github.com>.
@yc-huang what did you mean? The `try_from` function will deserialize `FaceDetectionArguments` based on its fields automatically. No need to change this function.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/402#issuecomment-670088462