[GitHub] [trafficserver] rob05c opened a new pull request #7429: Fix parent connect fail segfault

[GitBox <gi...@apache.org>]

rob05c opened a new pull request #7429:
URL: https://github.com/apache/trafficserver/pull/7429


   Fixes a segfault when a parent connect fails. 
   
   HandleResponse is reading header variables that don't exist on connect fail. This fixes it to not read them if the connect failed. 
   
   Later code doesn't need what this does if the connect fails, this would have returned PARENT_RETRY_NONE anyway, since response_is_retryable returns false when !is_response_valid.
   
   It actually will retry, not in `case PARENT_RETRY:` but in the `default: TxnDebug("http_trans", "[hrfp] connection not alive");` which calls `find_server_and_update_current_info`.
   
   So, I believe this makes the retry work as it should.
   
   I manually tested, and saw a connect-failing parent retry thrice then try the origin, as expected.
   
   Also, this appears to maybe not happen in release builds. I couldn't reproduce. But the segfault happens with debug builds, and looking at the code, it's obvious why. I'm not sure how release builds don't segfault.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] jrushford merged pull request #7429: Fix parent connect fail segfault

[GitBox <gi...@apache.org>]

jrushford merged pull request #7429:
URL: https://github.com/apache/trafficserver/pull/7429


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org