[GitHub] [incubator-superset] robdiciuccio commented on a change in pull request #9054: [database] new, select star API migration

[GitBox <gi...@apache.org>]

robdiciuccio commented on a change in pull request #9054: [database] new, select star API migration
URL: https://github.com/apache/incubator-superset/pull/9054#discussion_r374822557
 
 

 ##########
 File path: superset/views/base_api.py
 ##########
 @@ -122,6 +122,9 @@ def _get_related_filter(self, datamodel, column_name: str, value: str) -> Filter
             )
         return filters
 
+    def incr_stats(self, action: str, func_name: str) -> None:
+        self.stats_logger.incr(f"{action}_{self.__class__.__name__}.{func_name}")
 
 Review comment:
   Nit: in this case, I would suggest the following structure:
   ```
   {self.__class__.__name__}.{func_name}.{action}
   ```
   Grouping by class name and function first makes it easier to perform glob-based selections on the consuming end.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org