You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Szabolcs Vasas <va...@gmail.com> on 2017/03/29 13:32:49 UTC
Re: Review Request 55259:
https://issues.apache.org/jira/browse/SQOOP-3008
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55259/#review170372
-----------------------------------------------------------
Hi Hu,
Thank you for your contribution, it seems completely reasonable since the lowerBound and upperBound parameters are always casted to BigDecimal.
I wonder why this problem was not discovered before I guess this part of the code is not covered with test cases.
Can you please add a unit test which proves that your solution works now?
Thanks,
Szabolcs
- Szabolcs Vasas
On March 29, 2017, 6:43 a.m., hu xiaodong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55259/
> -----------------------------------------------------------
>
> (Updated March 29, 2017, 6:43 a.m.)
>
>
> Review request for Sqoop, Andrew Bayer, Abraham Elmahrek, Ahmed Radwan, and Jarek Cecho.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/SQOOP-3008
>
> GenericJdbcPartitioner.constructTextConditions(String, Object, Object, String, String, boolean, boolean) may occur java.lang.ClassCastException
>
>
> Diffs
> -----
>
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java 77b486c
>
>
> Diff: https://reviews.apache.org/r/55259/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> hu xiaodong
>
>
Re: Review Request 55259:
https://issues.apache.org/jira/browse/SQOOP-3008
Posted by hu xiaodong <hu...@zte.com.cn>.
> On \u4e09\u6708 29, 2017, 1:32 p.m., Szabolcs Vasas wrote:
> > Hi Hu,
> >
> > Thank you for your contribution, it seems completely reasonable since the lowerBound and upperBound parameters are always casted to BigDecimal.
> > I wonder why this problem was not discovered before I guess this part of the code is not covered with test cases.
> >
> > Can you please add a unit test which proves that your solution works now?
> >
> > Thanks,
> > Szabolcs
Hi Szabolcs Vasas
I have added a unit test which proves that my solution works. The old code will throw java.lang.ClassCastException when execute the test unit I added.
please review it.
Thanks
Hu xiaodong
- hu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55259/#review170372
-----------------------------------------------------------
On \u4e09\u6708 30, 2017, 3:30 a.m., hu xiaodong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55259/
> -----------------------------------------------------------
>
> (Updated \u4e09\u6708 30, 2017, 3:30 a.m.)
>
>
> Review request for Sqoop, Andrew Bayer, Abraham Elmahrek, Ahmed Radwan, and Jarek Cecho.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/SQOOP-3008
>
> GenericJdbcPartitioner.constructTextConditions(String, Object, Object, String, String, boolean, boolean) may occur java.lang.ClassCastException
>
>
> Diffs
> -----
>
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java 77b486c
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java b250f94
>
>
> Diff: https://reviews.apache.org/r/55259/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> hu xiaodong
>
>