You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/03 16:42:41 UTC

[GitHub] [spark] bmarcott edited a comment on issue #26696: [WIP][SPARK-18886][CORE] Only reset scheduling delay timer if allocated slots are fully utilized

bmarcott edited a comment on issue #26696: [WIP][SPARK-18886][CORE] Only reset scheduling delay timer if allocated slots are fully utilized
URL: https://github.com/apache/spark/pull/26696#issuecomment-561250890
 
 
   @tgravescs reworeded the description for clarity, please lemme know if it still is not
   Timers per slot will have issues when a stage finishes while slots are waiting. Then the next stage would ignore locality for those slots. It is more natural to think of the stages/tasks as having timers since they are the ones being starved, not the resources/slots.
   
   The approach in this PR is similar to what Kay described. Only increase locality levels when your slots are not being utilized for some period of time.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org