You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/26 03:09:54 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5343: net/tcp/tcp_send_unbuffered: significantly boosted the throughput (to the level of tcp_sendfile)

xiaoxiang781216 commented on a change in pull request #5343:
URL: https://github.com/apache/incubator-nuttx/pull/5343#discussion_r792285654



##########
File path: net/tcp/tcp_send_unbuffered.c
##########
@@ -348,6 +348,10 @@ static uint16_t tcpsend_eventhandler(FAR struct net_driver_s *dev,
                  &pstate->snd_buffer[pstate->snd_acked],
                  sndlen);
 
+      /* Notify the device driver of the availability of TX data */
+
+      tcp_send_txnotify(psock, conn);

Review comment:
       I think the top level will call tcp_send_txnotify, why we need call here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org