You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/07/24 12:17:00 UTC

[jira] [Commented] (ARTEMIS-1987) Support configuring a default consumer window size via Address Settings

    [ https://issues.apache.org/jira/browse/ARTEMIS-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554178#comment-16554178 ] 

ASF GitHub Bot commented on ARTEMIS-1987:
-----------------------------------------

GitHub user cshannon opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2191

    ARTEMIS-1987 - Add consumer window size to AddressSettings

    Support configuring a default consumer window size via AddressSettings
    which will allow sensible defaults to be used by address type

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cshannon/activemq-artemis ARTEMIS-1987

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2191.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2191
    
----
commit 878b53e455e402ea0de0d64dcd53550f16273664
Author: Christopher L. Shannon (cshannon) <ch...@...>
Date:   2018-04-09T12:20:57Z

    ARTEMIS-1987 - Add consumer window size to AddressSettings
    
    Support configuring a default consumer window size via AddressSettings
    which will allow sensible defaults to be used by address type

----


> Support configuring a default consumer window size via Address Settings
> -----------------------------------------------------------------------
>
>                 Key: ARTEMIS-1987
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1987
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 2.6.2
>            Reporter: Christopher L. Shannon
>            Assignee: Christopher L. Shannon
>            Priority: Major
>             Fix For: 2.7.0
>
>
> In ActiveMQ 5.x a very useful feature is the ability to configure a prefetch in a policy which then gets negotiated with an OpenWire client.  This allows changing the default prefetch setting by destination which is important because different destinations will have different message types and data flows.  It's very useful to be able to configure it on the broker so that each client doesn't need to configure their side and an administrator can set a reasonable default (where the broker is shared by multiple clients/customers)
> To do this in Artemis I'm proposing creating a new window size negotiation as part of the consumer creation.  Essentially the address can be configured with a different default window size if desired and if the client does not set the window size then the new configured default will be sent to the client which can be used instead of the standard 1 MiB.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)