[GitHub] [drill] vdiravka commented on a change in pull request #2432: DRILL-7994: Dependency version updates for severe vulnerabilities

[GitBox <gi...@apache.org>]

vdiravka commented on a change in pull request #2432:
URL: https://github.com/apache/drill/pull/2432#discussion_r788851627



##########
File path: pom.xml
##########
@@ -104,7 +104,7 @@
     <license.skip>true</license.skip>
     <docker.repository>apache/drill</docker.repository>
     <antlr.version>4.8-1</antlr.version>
-    <maven.version>3.6.3</maven.version>
+    <maven.version>3.8.4</maven.version>

Review comment:
       Could you try to build the project with this version? Is that used for current CI builds?

##########
File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpScanBatchCreator.java
##########
@@ -161,8 +161,8 @@ public void bind(ManagedScanFramework framework) { }
         }
       } else if (paginatorConfig != null) {
         /*
-        * If the paginator is not null and generated a list of URLs, we create
-        * a new batch reader for each URL.  In the future, this could be parallelized in
+        * If the paginator is not null we create a new batch reader for each
+        * URL that it generates.  In the future, this could be parallelized in

Review comment:
       ```suggestion
           * URL that it generates. In the future, this could be parallelized in
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org