You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/12/07 14:55:24 UTC
[GitHub] [camel-k] apupier opened a new issue #2817: Use deprecated field of yaml schema specification instead of only modifying description
apupier opened a new issue #2817:
URL: https://github.com/apache/camel-k/issues/2817
There is a deprecated field in specification http://json-schema.org/draft/2019-09/json-schema-validation.html#rfc.section.9.3
it would be nice to use it instead of mentioning the deprecation only in description field like here https://github.com/apache/camel-k/blob/48422c08bc20295d09cb31694adc177726806d6b/helm/camel-k/crds/crd-kamelet.yaml#L217
it will allow various tooling to make it more visible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez edited a comment on issue #2817: Use deprecated field of yaml schema specification instead of only modifying description
Posted by GitBox <gi...@apache.org>.
squakez edited a comment on issue #2817:
URL: https://github.com/apache/camel-k/issues/2817#issuecomment-988081536
Yeah, it would be good to have. We are generating the CRDs with some tooling and I haven't found an immediate way to declare the value is deprecated, ie `Resources []ResourceSpec json:"resources,omitempty,deprecated"`. Not sure if it exists some struct label that is taken in consideration when we generate the CRDs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on issue #2817: Use deprecated field of yaml schema specification instead of only modifying description
Posted by GitBox <gi...@apache.org>.
squakez commented on issue #2817:
URL: https://github.com/apache/camel-k/issues/2817#issuecomment-988093329
Maybe we're lucky if we bump the gen-tool version: https://github.com/kubernetes-sigs/controller-tools/pull/541
Going to have a look later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on issue #2817: Use deprecated field of yaml schema specification instead of only modifying description
Posted by GitBox <gi...@apache.org>.
astefanutti commented on issue #2817:
URL: https://github.com/apache/camel-k/issues/2817#issuecomment-988099391
While CRD structural schemas rely on OpenAPI v3 schemas, there are some limitations. The `deprecated` field cannot be set, as documented in:
https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#validation
The `+kubebuilder:deprecatedversion` marker applies at the CRD level, not the field level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on issue #2817: Use deprecated field of yaml schema specification instead of only modifying description
Posted by GitBox <gi...@apache.org>.
squakez commented on issue #2817:
URL: https://github.com/apache/camel-k/issues/2817#issuecomment-988081536
Yeah, it would be good to have. We are generating the CRDs with some tooling and I haven't found an immediate way to declare the value is deprecated, ie `Resources []ResourceSpec `json:"resources,omitempty,deprecated"``. Not sure if it exists some struct label that is taken in consideration when we generate the CRDs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] apupier commented on issue #2817: Use deprecated field of yaml schema specification instead of only modifying description
Posted by GitBox <gi...@apache.org>.
apupier commented on issue #2817:
URL: https://github.com/apache/camel-k/issues/2817#issuecomment-1061504789
still an important feature even if upstream doesn't provide an out of the box solution currently
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] github-actions[bot] commented on issue #2817: Use deprecated field of yaml schema specification instead of only modifying description
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #2817:
URL: https://github.com/apache/camel-k/issues/2817#issuecomment-1061272258
This issue has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org