You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/06/23 12:39:29 UTC

[GitHub] [shardingsphere] terrymanu commented on pull request #10840: Improve the initialization of OptimizeContextFactory for issue#10678

terrymanu commented on pull request #10840:
URL: https://github.com/apache/shardingsphere/pull/10840#issuecomment-866799719


   > > Hi @totalo ,
   > > Thanks for your continued improvement. This PR looks fine with me, and we can consider the following two points for the next PR,
   > > 
   > > 1. Remove the stale `StandardMetaDataContexts ` constructor
   > > 2. Add a tableName field in `TableMetaData` wo avoid `Map<Map<String, TableMetaData>, Map<String, TableMetaData>> build()`
   > > 
   > > Also, @Beyondeclipse, do you think this PR has room to improve in #10911? Could you give more explanation?
   > > @terrymanu , could you have a look at `ShardingSphereRulesBuilder.java` of this PR, since I saw it involves your `todo` comment?
   > 
   > OK, thank you. I will fix these two problems as soon as possible.
   
   Sure, I checked the class `ShardingSphereRulesBuilder`, the `TODO` is fine, we can remove the comment now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org