You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/05/12 17:32:07 UTC
[GitHub] [hive] wecharyu opened a new pull request, #3288: HIVE-26227: Add support of catalog related statements for Hive ql
wecharyu opened a new pull request, #3288:
URL: https://github.com/apache/hive/pull/3288
### What changes were proposed in this pull request?
Implement the ddl statements related to catalog, the statements can refer to [HIVE-26227](https://issues.apache.org/jira/browse/HIVE-26227).
### Why are the changes needed?
To support basic ddl operation for catalog through Hive ql.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes, we should add these new statements to DDL Document.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Add a qtest `catalog.q`, can be test by command:
```bash
mvn test -Dtest=TestMiniLlapLocalCliDriver -Dqfile=catalog.q
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] wecharyu commented on pull request #3288: HIVE-26227: Add support of catalog related statements for Hive ql
Posted by GitBox <gi...@apache.org>.
wecharyu commented on PR #3288:
URL: https://github.com/apache/hive/pull/3288#issuecomment-1129845332
@pvary @deniskuzZ: Could you also review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a diff in pull request #3288: HIVE-26227: Add support of catalog related statements for Hive ql
Posted by GitBox <gi...@apache.org>.
pvary commented on code in PR #3288:
URL: https://github.com/apache/hive/pull/3288#discussion_r879182487
##########
ql/src/test/queries/clientpositive/perf/cbo_query49.q:
##########
@@ -45,10 +45,10 @@ select
union
select
'catalog' as channel
- ,catalog.item
- ,catalog.return_ratio
- ,catalog.return_rank
- ,catalog.currency_rank
+ ,`catalog`.item
Review Comment:
This is a backward incompatible change. Could we make the `catalog` a non-reserved keyword?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] boneanxs commented on pull request #3288: HIVE-26227: Add support of catalog related statements for Hive ql
Posted by GitBox <gi...@apache.org>.
boneanxs commented on PR #3288:
URL: https://github.com/apache/hive/pull/3288#issuecomment-1132402520
A very great work! it's much easier for us to manage catalogs with DDL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] closed pull request #3288: HIVE-26227: Add support of catalog related statements for Hive ql
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #3288: HIVE-26227: Add support of catalog related statements for Hive ql
URL: https://github.com/apache/hive/pull/3288
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] wecharyu commented on a diff in pull request #3288: HIVE-26227: Add support of catalog related statements for Hive ql
Posted by GitBox <gi...@apache.org>.
wecharyu commented on code in PR #3288:
URL: https://github.com/apache/hive/pull/3288#discussion_r879549813
##########
ql/src/test/queries/clientpositive/perf/cbo_query49.q:
##########
@@ -45,10 +45,10 @@ select
union
select
'catalog' as channel
- ,catalog.item
- ,catalog.return_ratio
- ,catalog.return_rank
- ,catalog.currency_rank
+ ,`catalog`.item
Review Comment:
Make sense, done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #3288: HIVE-26227: Add support of catalog related statements for Hive ql
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #3288:
URL: https://github.com/apache/hive/pull/3288#issuecomment-1250162086
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org