You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/04/02 16:40:47 UTC

[GitHub] [incubator-pinot] sunithabeeram opened a new pull request #4055: Handle exceptions during teardown

sunithabeeram opened a new pull request #4055:  Handle exceptions during teardown
URL: https://github.com/apache/incubator-pinot/pull/4055
 
 
   We see random integration test failures in SegmentStatusCheckerIntegrationTest.tearDown
   with the trace:  
   java.lang.NullPointerException
   at org.apache.helix.participant.HelixStateMachineEngine.reset(HelixStateMachineEngine.java:156)
   at org.apache.helix.messaging.handling.HelixTaskExecutor.reset(HelixTaskExecutor.java:602)
   at org.apache.helix.messaging.handling.HelixTaskExecutor.shutdown(HelixTaskExecutor.java:1128)
   at org.apache.helix.manager.zk.ZKHelixManager.disconnect(ZKHelixManager.java:701)
   at org.apache.pinot.server.starter.helix.HelixServerStarter.stop(HelixServerStarter.java:362)
   at org.apache.pinot.integration.tests.ClusterTest.stopServer(ClusterTest.java:227)
   at org.apache.pinot.integration.tests.controller.periodic.tasks.SegmentStatusCheckerIntegrationTest.tearDown(SegmentStatusCheckerIntegrationTest.java:282)
   
   Its unclear if this is due to an issue in Helix's task framework that has been fixed in subsequent releases. However, this does point to the case where the teardown might abort due to an exception (we attempt to stop broker, server and minion) and an unclean shutdown *may* cause other issues.
   
   This change just  handles exceptions so we can still proceed with the rest of the cleanup.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org