You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by "v_iftodi_oodrive (JIRA)" <ji...@apache.org> on 2016/03/16 15:32:33 UTC
[jira] [Commented] (MTOMCAT-305) shutdown not correct working if
embedded tomcat is started twice in same maven build
[ https://issues.apache.org/jira/browse/MTOMCAT-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15197389#comment-15197389 ]
v_iftodi_oodrive commented on MTOMCAT-305:
------------------------------------------
Hello,
This merge request https://github.com/apache/tomcat-maven-plugin/pull/17 has existed for a while and claim (looking at the code it seems as well) to fix this issue.
Will this be merged? I have encountered the same issue and it took a while for me to find the reason.
> shutdown not correct working if embedded tomcat is started twice in same maven build
> ------------------------------------------------------------------------------------
>
> Key: MTOMCAT-305
> URL: https://issues.apache.org/jira/browse/MTOMCAT-305
> Project: Apache Tomcat Maven Plugin
> Issue Type: Bug
> Components: tomcat7
> Affects Versions: 2.2
> Environment: multi-module project
> Reporter: Oriel Maute
> Assignee: Olivier Lamy (*$^¨%`£)
> Labels: maven
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> We have a multi-module project with the modules A and B.
> In module A we start and stop an embedded tomcat server within our integration tests; same in module B.
> The integration-tests for module A work perfectly. But after this, the start of the embedded tomcat server for module B is not working because the port 8080 is still in use from the integration test of module A.
> The reason is that the shutdown on module A invokes on the Catalina Container the "stop()" method, this method does not unbind the port 8080.
> I think - specially in this scenario - the shutdown mojo should also invoke the "destroy()" method after the "stop()" method on the Catalina Container. If this is not possible in every case, it would be great to have a parameter for the shutdown goal to specify if "stop" or "stop & destroy" should be called on the Catalina Container.
> <plugins>
> <plugin>
> <groupId>org.apache.tomcat.maven</groupId>
> <artifactId>tomcat7-maven-plugin</artifactId>
> <version>2.2</version>
> <executions>
> <execution>
> <id>tomcat-run</id>
> <goals>
> <goal>run-war-only</goal>
> </goals>
> <phase>pre-integration-test</phase>
> </execution>
> <execution>
> <id>tomcat-shutdown</id>
> <goals>
> <goal>shutdown</goal>
> </goals>
> <phase>post-integration-test</phase>
> </execution>
> </executions>
> <configuration>
> <port>8080</port>
> <fork>true</fork>
> </configuration>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org