You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2015/06/09 22:36:04 UTC
Review Request 35267: Views : By default do not delete view data when
View archive is removed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35267/
-----------------------------------------------------------
Review request for Ambari, Nate Cole and Robert Levas.
Bugs: AMBARI-11818
https://issues.apache.org/jira/browse/AMBARI-11818
Repository: ambari
Description
-------
In order to avoid costly mistakes by customers during view upgrade process, Ambari should not automatically delete view data if a view archive is removed.
Add ambari.properties option to enable ...
views.remove.undeployed=true
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 318e8b3
ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 3ee2c5a
ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java 0823f99
ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java a8c938f
Diff: https://reviews.apache.org/r/35267/diff/
Testing
-------
Manual tested.
New unit tests added.
mvn clean test
all pass
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 46:19 min
[INFO] Finished at: 2015-06-09T16:09:30-04:00
[INFO] Final Memory: 55M/1638M
[INFO] ------------------------------------------------------------------------
Thanks,
Tom Beerbower
Re: Review Request 35267: Views : By default do not delete view data
when View archive is removed
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35267/#review87287
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Levas
On June 9, 2015, 4:36 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35267/
> -----------------------------------------------------------
>
> (Updated June 9, 2015, 4:36 p.m.)
>
>
> Review request for Ambari, Nate Cole and Robert Levas.
>
>
> Bugs: AMBARI-11818
> https://issues.apache.org/jira/browse/AMBARI-11818
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In order to avoid costly mistakes by customers during view upgrade process, Ambari should not automatically delete view data if a view archive is removed.
>
> Add ambari.properties option to enable ...
> views.remove.undeployed=true
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 318e8b3
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 3ee2c5a
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java 0823f99
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java a8c938f
>
> Diff: https://reviews.apache.org/r/35267/diff/
>
>
> Testing
> -------
>
> Manual tested.
>
> New unit tests added.
>
> mvn clean test
>
> all pass
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 46:19 min
> [INFO] Finished at: 2015-06-09T16:09:30-04:00
> [INFO] Final Memory: 55M/1638M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 35267: Views : By default do not delete view data
when View archive is removed
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35267/#review87392
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On June 9, 2015, 4:36 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35267/
> -----------------------------------------------------------
>
> (Updated June 9, 2015, 4:36 p.m.)
>
>
> Review request for Ambari, Nate Cole and Robert Levas.
>
>
> Bugs: AMBARI-11818
> https://issues.apache.org/jira/browse/AMBARI-11818
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In order to avoid costly mistakes by customers during view upgrade process, Ambari should not automatically delete view data if a view archive is removed.
>
> Add ambari.properties option to enable ...
> views.remove.undeployed=true
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 318e8b3
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 3ee2c5a
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java 0823f99
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java a8c938f
>
> Diff: https://reviews.apache.org/r/35267/diff/
>
>
> Testing
> -------
>
> Manual tested.
>
> New unit tests added.
>
> mvn clean test
>
> all pass
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 46:19 min
> [INFO] Finished at: 2015-06-09T16:09:30-04:00
> [INFO] Final Memory: 55M/1638M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>