[GitHub] [couchdb] jjrodrig opened a new pull request #2646: Port http, method_override and jsonp tests into elixir test suite

[GitBox <gi...@apache.org>]

jjrodrig opened a new pull request #2646: Port http, method_override and jsonp tests into elixir test suite
URL: https://github.com/apache/couchdb/pull/2646
 
 
   <!-- Thank you for your contribution!
   
        Please file this form by replacing the Markdown comments
        with your text. If a section needs no action - remove it.
   
        Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
        of code collaboration. Positive feedback is represented +1 from committers
        and negative is a -1. The -1 also means veto, and needs to be addressed
        to proceed. Once there are no objections, the PR can be merged by a
        CouchDB committer.
   
        See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
   
   ## Overview
   This PR ports the following tests into the elixir test suite:
   - http.js
   - method_override.js
   - jsonp.js
   
   <!-- Please give a short brief for the pull request,
        what problem it solves or how it makes things better. -->
   
   ## Testing recommendations
   ```
    make elixir tests=test/elixir/test/http_test.exs
    make elixir tests=test/elixir/test/method_override_test.exs
    make elixir tests=test/elixir/test/jsonp_test.exs
   ```
   
   <!-- Describe how we can test your changes.
        Does it provides any behaviour that the end users
        could notice? -->
   
   ## Related Issues or Pull Requests
   N/A
   <!-- If your changes affects multiple components in different
        repositories please put links to those issues or pull requests here.  -->
   
   ## Checklist
   
   - [X] Code is written and works correctly
   - [ ] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb] dottorblaster commented on a change in pull request #2646: Port http, method_override and jsonp tests into elixir test suite

[GitBox <gi...@apache.org>]

dottorblaster commented on a change in pull request #2646: Port http, method_override and jsonp tests into elixir test suite
URL: https://github.com/apache/couchdb/pull/2646#discussion_r395576649
 
 

 ##########
 File path: test/javascript/tests/changes.js
 ##########
 @@ -11,13 +11,14 @@
 // the License.
 
 function jsonp(obj) {
-  return console.log('done in test/elixir/test/changes_test.exs and changes_async_test.exs');
   T(jsonp_flag == 0);
   T(obj.results.length == 1 && obj.last_seq == 1, "jsonp");
   jsonp_flag = 1;
 }
 
 couchTests.changes = function(debug) {
+  return console.log('done in test/elixir/test/changes_test.exs and changes_async_test.exs');
 
 Review comment:
   Couldn't you add `couchTests.elixir = true;` to this too?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb] jjrodrig merged pull request #2646: Port http, method_override and jsonp tests into elixir test suite

[GitBox <gi...@apache.org>]

jjrodrig merged pull request #2646: Port http, method_override and jsonp tests into elixir test suite
URL: https://github.com/apache/couchdb/pull/2646
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services