You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "okumin (via GitHub)" <gi...@apache.org> on 2025/06/24 09:53:44 UTC
[PR] HIVE-29038: Make catalog servlet parameters generic [hive]
okumin opened a new pull request, #5893:
URL: https://github.com/apache/hive/pull/5893
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Change the parameter names for Iceberg REST API.
### Why are the changes needed?
We discussed the possibility of adding new catalogs, such as HMS v2 or Unity Catalog. We concluded that we would like to consolidate common properties, especially auth methods.
https://issues.apache.org/jira/browse/HIVE-29038
This PR will not change the following endpoints. As they have already been shipped as of 4.0.0, we can't silently change the params.
- HMS over HTTP
- Properties API
### Does this PR introduce _any_ user-facing change?
No. Iceberg REST API has not been released yet.
### How was this patch tested?
I locally built the docker image and tested it with Trino.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29038: Make catalog servlet parameters generic [hive]
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ merged PR #5893:
URL: https://github.com/apache/hive/pull/5893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29038: Make catalog servlet parameters generic [hive]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #5893:
URL: https://github.com/apache/hive/pull/5893#issuecomment-3001084599
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5893) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5893&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5893&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=5893&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5893&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5893&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5893)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29038: Make catalog servlet parameters generic [hive]
Posted by "okumin (via GitHub)" <gi...@apache.org>.
okumin commented on code in PR #5893:
URL: https://github.com/apache/hive/pull/5893#discussion_r2163496660
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -1853,26 +1853,26 @@ public enum ConfVars {
new StringSetValidator("simple", "jwt"),
"Property-maps servlet authentication method (simple or jwt)."
),
- ICEBERG_CATALOG_SERVLET_FACTORY("metastore.iceberg.catalog.servlet.factory",
- "hive.metastore.iceberg.catalog.servlet.factory",
- "org.apache.iceberg.rest.HMSCatalogFactory",
- "HMS Iceberg Catalog servlet factory class name."
+ CATALOG_SERVLET_FACTORY("metastore.catalog.servlet.factory",
+ "hive.metastore.catalog.servlet.factory",
+ "org.apache.iceberg.rest.HMSCatalogFactory",
+ "HMS Catalog servlet factory class name. The default serves Iceberg REST API."
+ "The factory needs to expose a method: "
+ "public static HttpServlet createServlet(Configuration configuration);"
),
- ICEBERG_CATALOG_SERVLET_PATH("metastore.iceberg.catalog.servlet.path",
- "hive.metastore.iceberg.catalog.servlet.path", "iceberg",
- "HMS Iceberg Catalog servlet path component of URL endpoint."
- ),
- ICEBERG_CATALOG_SERVLET_PORT("metastore.iceberg.catalog.servlet.port",
- "hive.metastore.iceberg.catalog.servlet.port", -1,
- "HMS Iceberg Catalog servlet server port. Negative value disables the servlet," +
+ CATALOG_SERVLET_PORT("metastore.catalog.servlet.port",
+ "hive.metastore.catalog.servlet.port", -1,
+ "HMS Catalog servlet server port. Negative value disables the servlet," +
" 0 will let the system determine the catalog server port," +
" positive value will be used as-is."
),
- ICEBERG_CATALOG_SERVLET_AUTH("metastore.iceberg.catalog.servlet.auth",
- "hive.metastore.iceberg.catalog.servlet.auth", "jwt", new StringSetValidator("none", "simple", "jwt"),
- "HMS Iceberg Catalog servlet authentication method (none, simple, or jwt)."
+ CATALOG_SERVLET_AUTH("metastore.catalog.servlet.auth",
+ "hive.metastore.catalog.servlet.auth", "jwt", new StringSetValidator("none", "simple", "jwt"),
+ "HMS Catalog servlet authentication method (none, simple, or jwt)."
+ ),
+ ICEBERG_CATALOG_SERVLET_PATH("metastore.iceberg.catalog.servlet.path",
Review Comment:
I kept `ICEBERG_CATALOG_SERVLET_PATH` and `ICEBERG_CATALOG_CACHE_EXPIRY` because they really sound specific to the Iceberg REST endpoint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29038: Make catalog servlet parameters generic [hive]
Posted by "okumin (via GitHub)" <gi...@apache.org>.
okumin commented on PR #5893:
URL: https://github.com/apache/hive/pull/5893#issuecomment-2999628120
@deniskuzZ @zhangbutao Does this align with your expectations? If yes, I wonder if we will merge this before cutting the 4.1 branch.
As good news, the current implementation worked with Trino 🥳
https://issues.apache.org/jira/browse/HIVE-28998?focusedCommentId=17985825&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17985825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29038: Make catalog servlet parameters generic [hive]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #5893:
URL: https://github.com/apache/hive/pull/5893#issuecomment-3000010963
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5893) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5893&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5893&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=5893&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5893&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5893&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5893)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29038: Make catalog servlet parameters generic [hive]
Posted by "okumin (via GitHub)" <gi...@apache.org>.
okumin commented on PR #5893:
URL: https://github.com/apache/hive/pull/5893#issuecomment-3002061555
Thanks for merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29038: Make catalog servlet parameters generic [hive]
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on PR #5893:
URL: https://github.com/apache/hive/pull/5893#issuecomment-2999759522
> @deniskuzZ @zhangbutao Does this align with your expectations? If yes, I wonder if we will merge this before cutting the 4.1 branch. As good news, the current implementation worked with Trino 🥳 https://issues.apache.org/jira/browse/HIVE-28998?focusedCommentId=17985825&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17985825
Sorry folks, I was occupied with many other things and didn't have time to thing much about the API design. The change in the PR aligns with my original intent, though I began to question it after the discussion in https://github.com/apache/hive/pull/5870#discussion_r2158831458.
ATM I am OK with either approach, though I’m leaning slightly toward the more generic one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org