You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Hoss Man (JIRA)" <ji...@apache.org> on 2013/04/03 03:16:14 UTC
[jira] [Updated] (SOLR-4629) Stronger standard replication testing.
[ https://issues.apache.org/jira/browse/SOLR-4629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man updated SOLR-4629:
---------------------------
Attachment: SOLR-4629_emptycommittest_and_numfoundrefactor_and_waitparam.patch
[~markrmiller@gmail.com]: can you please sanity check this patch for me?
The initial motivation was adding "testEmptyCommits" to help verify that the situation observed in SOLR-4661 didn't actually cause any problems.
Since a key point of the new test was to ensure that replication happened even if no new docs were added by a commit, i couldn't rely on the existing hack of "rQuery", so i added a "wait" option to command=fetchindex that causes the command request to block until the Thread running doFetch finishes (here's where my first concern is: is having this option a bad idea? should we document it or keep it hidden for tests?)
since i was looking at rQuery, i noticed it was sleeping at least 100ms on every call, even if the results were already available, so i reworked that a bit, and in the process refactored a "numFound" helper utility.
----
Assuming this patch -- in particular the "wait" option on fetch index -- seems ok to folks, i think we could probably speed up TestReplicationhandler considerably by changing all of the individual tests to explicitly call pullFromMasterToSlave() instead of using rQuery to wait for polling ... it seems like we should really only need a single test of the polling feature, everything else being tested can be verified with blocking calls to command=fetchindex ... right?
> Stronger standard replication testing.
> --------------------------------------
>
> Key: SOLR-4629
> URL: https://issues.apache.org/jira/browse/SOLR-4629
> Project: Solr
> Issue Type: Test
> Components: replication (java)
> Reporter: Mark Miller
> Assignee: Mark Miller
> Fix For: 4.3, 5.0, 4.2.1
>
> Attachments: SOLR-4629_emptycommittest_and_numfoundrefactor_and_waitparam.patch
>
>
> I added to these tests recently, but there is a report on the list indicating we may still be missing something. Most reports have been positive so far after the 4.2 fixes, but I'd feel better after adding some more testing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org