You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/05/27 03:40:01 UTC

[GitHub] [incubator-pinot] kishoreg opened a new pull request #5441: Adding files generated by running quickstart to gitignore

kishoreg opened a new pull request #5441:
URL: https://github.com/apache/incubator-pinot/pull/5441


   Quickstart generates additional files in the directory and its annoying to see them as part of git status.
   
   ```
   Untracked files:
     (use "git add <file>..." to include in what will be committed)
   
           examples/
           quickStartData1589785258792/
           quickStartData1589786369065/
           quickStartData1589786485590/
           quickStartData1589786542192/
   
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] kishoreg merged pull request #5441: Adding files generated by running quickstart to gitignore

Posted by GitBox <gi...@apache.org>.
kishoreg merged pull request #5441:
URL: https://github.com/apache/incubator-pinot/pull/5441


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #5441: Adding files generated by running quickstart to gitignore

Posted by GitBox <gi...@apache.org>.
kishoreg commented on a change in pull request #5441:
URL: https://github.com/apache/incubator-pinot/pull/5441#discussion_r432151926



##########
File path: .gitignore
##########
@@ -44,4 +44,8 @@ yarn.lock
 
 npm-debug.log*
 yarn-debug.log*
-yarn-error.log*
\ No newline at end of file
+yarn-error.log*
+
+#quickstart files
+examples/

Review comment:
       This only excludes examples in the root folder.
   
   ```
   ➜  incubator-pinot git:(ignore-quickstart-files) git status
   On branch ignore-quickstart-files
   Changes not staged for commit:
     (use "git add <file>..." to update what will be committed)
     (use "git checkout -- <file>..." to discard changes in working directory)
   
           modified:   pinot-tools/src/main/resources/examples/batch/airlineStats/hadoopIngestionJobSpec.yaml
   
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5441: Adding files generated by running quickstart to gitignore

Posted by GitBox <gi...@apache.org>.
fx19880617 commented on a change in pull request #5441:
URL: https://github.com/apache/incubator-pinot/pull/5441#discussion_r430280846



##########
File path: .gitignore
##########
@@ -44,4 +44,8 @@ yarn.lock
 
 npm-debug.log*
 yarn-debug.log*
-yarn-error.log*
\ No newline at end of file
+yarn-error.log*
+
+#quickstart files
+examples/

Review comment:
       we have some directories named examples under `resources`, will this make git ignoring them?

##########
File path: .gitignore
##########
@@ -44,4 +44,8 @@ yarn.lock
 
 npm-debug.log*
 yarn-debug.log*
-yarn-error.log*
\ No newline at end of file
+yarn-error.log*
+
+#quickstart files
+examples/

Review comment:
       we have some directories named examples under `resources`, will this make git ignoring them?
   E.g.
   ```
   ./docker/images/pinot-superset/examples
   ./pinot-tools/src/main/resources/examples
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org