You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Devdeep Singh <de...@citrix.com> on 2013/04/16 09:01:41 UTC
Review Request: NPE while migrating volume
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10539/
-----------------------------------------------------------
Review request for cloudstack and edison su.
Description
-------
The state transitions on the volume that has to be migrated were incorrect. A volume to be migrated is in ready state and cannot be transitioned to copying state. Similarly, the duplicated volume is in ready state too and cannot be transitioned to creating state. Fixed it by transitioning the volume to migrating state when a migrateVolume api call is made. Also, a volume has to be destroyed first before it can be expunged. Fixed that too.
This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1879.
Diffs
-----
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/ObjectInDataStoreStateMachine.java f619ef4
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeObject.java ceadb25
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java 32e7d27
Diff: https://reviews.apache.org/r/10539/diff/
Testing
-------
1. migrated a volume from one storage pool to another and made sure it was successful. Attached it to a vm after migrating.
2. Also verified that the patch applies successfully.
Thanks,
Devdeep Singh
Re: Review Request: NPE while migrating volume
Posted by Abhinandan Prateek <ap...@apache.org>.
> On April 19, 2013, 10:43 a.m., Abhinandan Prateek wrote:
> > Ship It!
committed
- Abhinandan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10539/#review19449
-----------------------------------------------------------
On April 19, 2013, 9:34 a.m., Devdeep Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10539/
> -----------------------------------------------------------
>
> (Updated April 19, 2013, 9:34 a.m.)
>
>
> Review request for cloudstack and edison su.
>
>
> Description
> -------
>
> The state transitions on the volume that has to be migrated were incorrect. A volume to be migrated is in ready state and cannot be transitioned to copying state. Similarly, the duplicated volume is in ready state too and cannot be transitioned to creating state. Fixed it by transitioning the volume to migrating state when a migrateVolume api call is made. Also, a volume has to be destroyed first before it can be expunged. Fixed that too.
>
>
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1879.
>
>
> Diffs
> -----
>
> engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java e3526de
>
> Diff: https://reviews.apache.org/r/10539/diff/
>
>
> Testing
> -------
>
> 1. migrated a volume from one storage pool to another and made sure it was successful. Attached it to a vm after migrating.
> 2. Also verified that the patch applies successfully.
>
>
> Thanks,
>
> Devdeep Singh
>
>
Re: Review Request: NPE while migrating volume
Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10539/#review19449
-----------------------------------------------------------
Ship it!
Ship It!
- Abhinandan Prateek
On April 19, 2013, 9:34 a.m., Devdeep Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10539/
> -----------------------------------------------------------
>
> (Updated April 19, 2013, 9:34 a.m.)
>
>
> Review request for cloudstack and edison su.
>
>
> Description
> -------
>
> The state transitions on the volume that has to be migrated were incorrect. A volume to be migrated is in ready state and cannot be transitioned to copying state. Similarly, the duplicated volume is in ready state too and cannot be transitioned to creating state. Fixed it by transitioning the volume to migrating state when a migrateVolume api call is made. Also, a volume has to be destroyed first before it can be expunged. Fixed that too.
>
>
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1879.
>
>
> Diffs
> -----
>
> engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java e3526de
>
> Diff: https://reviews.apache.org/r/10539/diff/
>
>
> Testing
> -------
>
> 1. migrated a volume from one storage pool to another and made sure it was successful. Attached it to a vm after migrating.
> 2. Also verified that the patch applies successfully.
>
>
> Thanks,
>
> Devdeep Singh
>
>
Re: Review Request: NPE while migrating volume
Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10539/
-----------------------------------------------------------
(Updated April 19, 2013, 9:34 a.m.)
Review request for cloudstack and edison su.
Changes
-------
Updated the patch after merging with the latest changes on master.
Description
-------
The state transitions on the volume that has to be migrated were incorrect. A volume to be migrated is in ready state and cannot be transitioned to copying state. Similarly, the duplicated volume is in ready state too and cannot be transitioned to creating state. Fixed it by transitioning the volume to migrating state when a migrateVolume api call is made. Also, a volume has to be destroyed first before it can be expunged. Fixed that too.
This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1879.
Diffs (updated)
-----
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java e3526de
Diff: https://reviews.apache.org/r/10539/diff/
Testing
-------
1. migrated a volume from one storage pool to another and made sure it was successful. Attached it to a vm after migrating.
2. Also verified that the patch applies successfully.
Thanks,
Devdeep Singh
Re: Review Request: NPE while migrating volume
Posted by edison su <ed...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10539/#review19307
-----------------------------------------------------------
Ship it!
Ship It!
- edison su
On April 16, 2013, 7:01 a.m., Devdeep Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10539/
> -----------------------------------------------------------
>
> (Updated April 16, 2013, 7:01 a.m.)
>
>
> Review request for cloudstack and edison su.
>
>
> Description
> -------
>
> The state transitions on the volume that has to be migrated were incorrect. A volume to be migrated is in ready state and cannot be transitioned to copying state. Similarly, the duplicated volume is in ready state too and cannot be transitioned to creating state. Fixed it by transitioning the volume to migrating state when a migrateVolume api call is made. Also, a volume has to be destroyed first before it can be expunged. Fixed that too.
>
>
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1879.
>
>
> Diffs
> -----
>
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/ObjectInDataStoreStateMachine.java f619ef4
> engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeObject.java ceadb25
> engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java 32e7d27
>
> Diff: https://reviews.apache.org/r/10539/diff/
>
>
> Testing
> -------
>
> 1. migrated a volume from one storage pool to another and made sure it was successful. Attached it to a vm after migrating.
> 2. Also verified that the patch applies successfully.
>
>
> Thanks,
>
> Devdeep Singh
>
>