You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Carsten Ziegeler (JIRA)" <ji...@apache.org> on 2013/07/03 15:13:20 UTC
[jira] [Assigned] (SLING-2925) Wasted work in
InternalQueueConfiguration.checkIsValid()
[ https://issues.apache.org/jira/browse/SLING-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler reassigned SLING-2925:
---------------------------------------
Assignee: Carsten Ziegeler
> Wasted work in InternalQueueConfiguration.checkIsValid()
> --------------------------------------------------------
>
> Key: SLING-2925
> URL: https://issues.apache.org/jira/browse/SLING-2925
> Project: Sling
> Issue Type: Bug
> Components: Scripting
> Environment: any
> Reporter: Adrian Nistor
> Assignee: Carsten Ziegeler
> Labels: patch, performance
> Attachments: patch.diff
>
>
> The problem appears in version 6 and in revision 1495454. I attached
> a one-line patch that fixes it.
> In method "InternalQueueConfiguration.checkIsValid", the loop over
> "matchers" should break immediately after "hasMatchers" is set to
> "true". All the iterations after "hasMatchers" is set to "true" do
> not perform any useful work, at best they just set "hasMatchers" again
> to "true".
> Method "isLive" in class "ResourceResolverContext" has a similar loop
> (over "dynamicProviders"), and this loop breaks immediately after
> "result" is set to "false", just like in the proposed patch. Other
> methods (e.g., "FactoryPreconditions.checkPreconditions",
> "JspUtil.checkAttributes", "EclipseJavaCompiler.compile",
> "SecondPassVisitor.appendPageDirective") also have similar loops with
> similar breaks, just like in the proposed patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira