You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Tony Dong <to...@gmail.com> on 2016/04/05 23:51:57 UTC

Review Request 45779: Small Documentation fixes and nitpicks.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45779/
-----------------------------------------------------------

Review request for Aurora, Stephan Erb and Bill Farner.


Repository: aurora


Description
-------

Small Documentation fixes and nitpicks.


Diffs
-----

  docs/additional-resources/tools.md 354ccf07b5d457aff387cfa7cc775fea79b3a387 
  docs/development/client.md 7d0c2309983cb2151af2022997f0f7432f4d2d3d 
  docs/development/committers-guide.md 309a6522ec9e8750c7b13e211eca7517b358a05f 
  docs/development/scheduler.md a26dfadf2963538c91c04224540312e01c7f70ae 
  docs/getting-started/overview.md 854f8d7109a1c7d94dfa960f169d796faba95f87 

Diff: https://reviews.apache.org/r/45779/diff/


Testing
-------


Thanks,

Tony Dong


Re: Review Request 45779: Small Documentation fixes and nitpicks.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45779/#review127235
-----------------------------------------------------------


Ship it!




Master (5109788) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On April 5, 2016, 9:51 p.m., Tony Dong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45779/
> -----------------------------------------------------------
> 
> (Updated April 5, 2016, 9:51 p.m.)
> 
> 
> Review request for Aurora, Stephan Erb and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Small Documentation fixes and nitpicks.
> 
> 
> Diffs
> -----
> 
>   docs/additional-resources/tools.md 354ccf07b5d457aff387cfa7cc775fea79b3a387 
>   docs/development/client.md 7d0c2309983cb2151af2022997f0f7432f4d2d3d 
>   docs/development/committers-guide.md 309a6522ec9e8750c7b13e211eca7517b358a05f 
>   docs/development/scheduler.md a26dfadf2963538c91c04224540312e01c7f70ae 
>   docs/getting-started/overview.md 854f8d7109a1c7d94dfa960f169d796faba95f87 
> 
> Diff: https://reviews.apache.org/r/45779/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tony Dong
> 
>


Re: Review Request 45779: Small Documentation fixes and nitpicks.

Posted by Tony Dong <to...@gmail.com>.

> On April 5, 2016, 10:06 p.m., Stephan Erb wrote:
> > Cool, thanks! I believe there is a dead link in the service ports section. Would you mind to fix that as well?

fixed.


- Tony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45779/#review127229
-----------------------------------------------------------


On April 5, 2016, 9:51 p.m., Tony Dong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45779/
> -----------------------------------------------------------
> 
> (Updated April 5, 2016, 9:51 p.m.)
> 
> 
> Review request for Aurora, Stephan Erb and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Small Documentation fixes and nitpicks.
> 
> 
> Diffs
> -----
> 
>   docs/additional-resources/tools.md 354ccf07b5d457aff387cfa7cc775fea79b3a387 
>   docs/development/client.md 7d0c2309983cb2151af2022997f0f7432f4d2d3d 
>   docs/development/committers-guide.md 309a6522ec9e8750c7b13e211eca7517b358a05f 
>   docs/development/scheduler.md a26dfadf2963538c91c04224540312e01c7f70ae 
>   docs/getting-started/overview.md 854f8d7109a1c7d94dfa960f169d796faba95f87 
> 
> Diff: https://reviews.apache.org/r/45779/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tony Dong
> 
>


Re: Review Request 45779: Small Documentation fixes and nitpicks.

Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45779/#review127229
-----------------------------------------------------------


Ship it!




Cool, thanks! I believe there is a dead link in the service ports section. Would you mind to fix that as well?

- Stephan Erb


On April 5, 2016, 11:51 nachm., Tony Dong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45779/
> -----------------------------------------------------------
> 
> (Updated April 5, 2016, 11:51 nachm.)
> 
> 
> Review request for Aurora, Stephan Erb and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Small Documentation fixes and nitpicks.
> 
> 
> Diffs
> -----
> 
>   docs/additional-resources/tools.md 354ccf07b5d457aff387cfa7cc775fea79b3a387 
>   docs/development/client.md 7d0c2309983cb2151af2022997f0f7432f4d2d3d 
>   docs/development/committers-guide.md 309a6522ec9e8750c7b13e211eca7517b358a05f 
>   docs/development/scheduler.md a26dfadf2963538c91c04224540312e01c7f70ae 
>   docs/getting-started/overview.md 854f8d7109a1c7d94dfa960f169d796faba95f87 
> 
> Diff: https://reviews.apache.org/r/45779/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tony Dong
> 
>


Re: Review Request 45779: Small Documentation fixes and nitpicks.

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45779/#review127345
-----------------------------------------------------------


Ship it!




LGTM mod previously-mentioned nits.

- Bill Farner


On April 6, 2016, 8:14 a.m., Tony Dong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45779/
> -----------------------------------------------------------
> 
> (Updated April 6, 2016, 8:14 a.m.)
> 
> 
> Review request for Aurora, Stephan Erb and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Small Documentation fixes and nitpicks.
> 
> 
> Diffs
> -----
> 
>   docs/additional-resources/tools.md 354ccf07b5d457aff387cfa7cc775fea79b3a387 
>   docs/development/client.md 7d0c2309983cb2151af2022997f0f7432f4d2d3d 
>   docs/development/committers-guide.md 309a6522ec9e8750c7b13e211eca7517b358a05f 
>   docs/development/scheduler.md a26dfadf2963538c91c04224540312e01c7f70ae 
>   docs/features/services.md 691fa28ad3e9476e4137bc23dbcda58f5e377387 
>   docs/getting-started/overview.md 854f8d7109a1c7d94dfa960f169d796faba95f87 
> 
> Diff: https://reviews.apache.org/r/45779/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tony Dong
> 
>


Re: Review Request 45779: Small Documentation fixes and nitpicks.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45779/#review127352
-----------------------------------------------------------



Master (b2df0eb) is red with this patch.
  ./build-support/jenkins/build.sh

                           self._clock.converge(threads=[hct.threaded_health_checker])
                           self._clock.assert_waiting(hct.threaded_health_checker, amount=1)  # interval_secs
                           assert hct._total_latency == 0.5
                           assert hct.metrics.sample()['total_latency_secs'] == 0.5
                           assert hct.metrics.sample()['checks'] == 1
                         
                           # tick again
                           self._clock.tick(1.0 + epsilon)
                           self._clock.converge(threads=[hct.threaded_health_checker])
                           self._clock.tick(0.5 + epsilon)
                           self._clock.converge(threads=[hct.threaded_health_checker])
                           self._clock.assert_waiting(hct.threaded_health_checker, amount=1)  # interval_secs
                     >     assert hct._total_latency == 1.0
                     E     AssertionError: assert 1.001 == 1.0
                     E      +  where 1.001 = <apache.aurora.executor.common.health_checker.HealthChecker object at 0x7fb44e118510>._total_latency
                     
                     src/test/python/apache/aurora/executor/common/test_health_checker.py:184: AssertionError
                     -------------- Captured stderr call --------------
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7fb44e118990>] Time now: 0.0
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7fb44e118990>] Time now: 0.0
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7fb44e118990>] Time now: 1.0
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7fb44e118990>] Time now: 1.001
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7fb44e118990>] Time now: 1.001
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7fb44e118990>] Time now: 1.501
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7fb44e118990>] Time now: 1.502
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7fb44e118990>] Time now: 1.502
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7fb44e118990>] Time now: 2.502
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7fb44e118990>] Time now: 2.503
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7fb44e118990>] Time now: 2.503
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7fb44e118990>] Time now: 3.003
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7fb44e118990>] Time now: 3.004
                      generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml 
                      1 failed, 664 passed, 5 skipped, 1 warnings in 271.62 seconds 
                     
FAILURE


               Waiting for background workers to finish.
16:05:37 06:16   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On April 6, 2016, 3:37 p.m., Tony Dong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45779/
> -----------------------------------------------------------
> 
> (Updated April 6, 2016, 3:37 p.m.)
> 
> 
> Review request for Aurora, Stephan Erb and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Small Documentation fixes and nitpicks.
> 
> 
> Diffs
> -----
> 
>   docs/additional-resources/tools.md 354ccf07b5d457aff387cfa7cc775fea79b3a387 
>   docs/development/client.md 7d0c2309983cb2151af2022997f0f7432f4d2d3d 
>   docs/development/committers-guide.md 309a6522ec9e8750c7b13e211eca7517b358a05f 
>   docs/development/scheduler.md a26dfadf2963538c91c04224540312e01c7f70ae 
>   docs/features/services.md 691fa28ad3e9476e4137bc23dbcda58f5e377387 
>   docs/getting-started/overview.md 854f8d7109a1c7d94dfa960f169d796faba95f87 
> 
> Diff: https://reviews.apache.org/r/45779/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tony Dong
> 
>


Re: Review Request 45779: Small Documentation fixes and nitpicks.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45779/#review127375
-----------------------------------------------------------


Ship it!




Master (b2df0eb) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On April 6, 2016, 3:37 p.m., Tony Dong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45779/
> -----------------------------------------------------------
> 
> (Updated April 6, 2016, 3:37 p.m.)
> 
> 
> Review request for Aurora, Stephan Erb and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Small Documentation fixes and nitpicks.
> 
> 
> Diffs
> -----
> 
>   docs/additional-resources/tools.md 354ccf07b5d457aff387cfa7cc775fea79b3a387 
>   docs/development/client.md 7d0c2309983cb2151af2022997f0f7432f4d2d3d 
>   docs/development/committers-guide.md 309a6522ec9e8750c7b13e211eca7517b358a05f 
>   docs/development/scheduler.md a26dfadf2963538c91c04224540312e01c7f70ae 
>   docs/features/services.md 691fa28ad3e9476e4137bc23dbcda58f5e377387 
>   docs/getting-started/overview.md 854f8d7109a1c7d94dfa960f169d796faba95f87 
> 
> Diff: https://reviews.apache.org/r/45779/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tony Dong
> 
>


Re: Review Request 45779: Small Documentation fixes and nitpicks.

Posted by Tony Dong <to...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45779/#review127362
-----------------------------------------------------------



@ReviewBot retry

- Tony Dong


On April 6, 2016, 3:37 p.m., Tony Dong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45779/
> -----------------------------------------------------------
> 
> (Updated April 6, 2016, 3:37 p.m.)
> 
> 
> Review request for Aurora, Stephan Erb and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Small Documentation fixes and nitpicks.
> 
> 
> Diffs
> -----
> 
>   docs/additional-resources/tools.md 354ccf07b5d457aff387cfa7cc775fea79b3a387 
>   docs/development/client.md 7d0c2309983cb2151af2022997f0f7432f4d2d3d 
>   docs/development/committers-guide.md 309a6522ec9e8750c7b13e211eca7517b358a05f 
>   docs/development/scheduler.md a26dfadf2963538c91c04224540312e01c7f70ae 
>   docs/features/services.md 691fa28ad3e9476e4137bc23dbcda58f5e377387 
>   docs/getting-started/overview.md 854f8d7109a1c7d94dfa960f169d796faba95f87 
> 
> Diff: https://reviews.apache.org/r/45779/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tony Dong
> 
>


Re: Review Request 45779: Small Documentation fixes and nitpicks.

Posted by Tony Dong <to...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45779/
-----------------------------------------------------------

(Updated April 6, 2016, 3:37 p.m.)


Review request for Aurora, Stephan Erb and Bill Farner.


Repository: aurora


Description
-------

Small Documentation fixes and nitpicks.


Diffs (updated)
-----

  docs/additional-resources/tools.md 354ccf07b5d457aff387cfa7cc775fea79b3a387 
  docs/development/client.md 7d0c2309983cb2151af2022997f0f7432f4d2d3d 
  docs/development/committers-guide.md 309a6522ec9e8750c7b13e211eca7517b358a05f 
  docs/development/scheduler.md a26dfadf2963538c91c04224540312e01c7f70ae 
  docs/features/services.md 691fa28ad3e9476e4137bc23dbcda58f5e377387 
  docs/getting-started/overview.md 854f8d7109a1c7d94dfa960f169d796faba95f87 

Diff: https://reviews.apache.org/r/45779/diff/


Testing
-------


Thanks,

Tony Dong


Re: Review Request 45779: Small Documentation fixes and nitpicks.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45779/#review127342
-----------------------------------------------------------


Ship it!




Master (a9b3df8) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On April 6, 2016, 3:14 p.m., Tony Dong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45779/
> -----------------------------------------------------------
> 
> (Updated April 6, 2016, 3:14 p.m.)
> 
> 
> Review request for Aurora, Stephan Erb and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Small Documentation fixes and nitpicks.
> 
> 
> Diffs
> -----
> 
>   docs/additional-resources/tools.md 354ccf07b5d457aff387cfa7cc775fea79b3a387 
>   docs/development/client.md 7d0c2309983cb2151af2022997f0f7432f4d2d3d 
>   docs/development/committers-guide.md 309a6522ec9e8750c7b13e211eca7517b358a05f 
>   docs/development/scheduler.md a26dfadf2963538c91c04224540312e01c7f70ae 
>   docs/features/services.md 691fa28ad3e9476e4137bc23dbcda58f5e377387 
>   docs/getting-started/overview.md 854f8d7109a1c7d94dfa960f169d796faba95f87 
> 
> Diff: https://reviews.apache.org/r/45779/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tony Dong
> 
>


Re: Review Request 45779: Small Documentation fixes and nitpicks.

Posted by Tony Dong <to...@gmail.com>.

> On April 6, 2016, 3:29 p.m., Joshua Cohen wrote:
> > docs/additional-resources/tools.md, line 8
> > <https://reviews.apache.org/r/45779/diff/2/?file=1328026#file1328026line8>
> >
> >     should really be "administrator" right? not "administer"?
> 
> Bill Farner wrote:
>     And `developer` rather than `developers`.

This sentence was a bit odd to read now that I think about it. Changing it.


> On April 6, 2016, 3:29 p.m., Joshua Cohen wrote:
> > docs/getting-started/overview.md, line 44
> > <https://reviews.apache.org/r/45779/diff/2/?file=1328031#file1328031line44>
> >
> >     s/Discover/Discovery
> >     
> >     I'd also recommend skipping the "see ..." bit, and just making the link on "vehicle for [service discovery](...)"

Done


- Tony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45779/#review127341
-----------------------------------------------------------


On April 6, 2016, 3:14 p.m., Tony Dong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45779/
> -----------------------------------------------------------
> 
> (Updated April 6, 2016, 3:14 p.m.)
> 
> 
> Review request for Aurora, Stephan Erb and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Small Documentation fixes and nitpicks.
> 
> 
> Diffs
> -----
> 
>   docs/additional-resources/tools.md 354ccf07b5d457aff387cfa7cc775fea79b3a387 
>   docs/development/client.md 7d0c2309983cb2151af2022997f0f7432f4d2d3d 
>   docs/development/committers-guide.md 309a6522ec9e8750c7b13e211eca7517b358a05f 
>   docs/development/scheduler.md a26dfadf2963538c91c04224540312e01c7f70ae 
>   docs/features/services.md 691fa28ad3e9476e4137bc23dbcda58f5e377387 
>   docs/getting-started/overview.md 854f8d7109a1c7d94dfa960f169d796faba95f87 
> 
> Diff: https://reviews.apache.org/r/45779/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tony Dong
> 
>


Re: Review Request 45779: Small Documentation fixes and nitpicks.

Posted by Bill Farner <wf...@apache.org>.

> On April 6, 2016, 8:29 a.m., Joshua Cohen wrote:
> > docs/additional-resources/tools.md, line 8
> > <https://reviews.apache.org/r/45779/diff/2/?file=1328026#file1328026line8>
> >
> >     should really be "administrator" right? not "administer"?

And `developer` rather than `developers`.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45779/#review127341
-----------------------------------------------------------


On April 6, 2016, 8:14 a.m., Tony Dong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45779/
> -----------------------------------------------------------
> 
> (Updated April 6, 2016, 8:14 a.m.)
> 
> 
> Review request for Aurora, Stephan Erb and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Small Documentation fixes and nitpicks.
> 
> 
> Diffs
> -----
> 
>   docs/additional-resources/tools.md 354ccf07b5d457aff387cfa7cc775fea79b3a387 
>   docs/development/client.md 7d0c2309983cb2151af2022997f0f7432f4d2d3d 
>   docs/development/committers-guide.md 309a6522ec9e8750c7b13e211eca7517b358a05f 
>   docs/development/scheduler.md a26dfadf2963538c91c04224540312e01c7f70ae 
>   docs/features/services.md 691fa28ad3e9476e4137bc23dbcda58f5e377387 
>   docs/getting-started/overview.md 854f8d7109a1c7d94dfa960f169d796faba95f87 
> 
> Diff: https://reviews.apache.org/r/45779/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tony Dong
> 
>


Re: Review Request 45779: Small Documentation fixes and nitpicks.

Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45779/#review127341
-----------------------------------------------------------




docs/additional-resources/tools.md (line 8)
<https://reviews.apache.org/r/45779/#comment190625>

    should really be "administrator" right? not "administer"?



docs/getting-started/overview.md (line 44)
<https://reviews.apache.org/r/45779/#comment190626>

    s/Discover/Discovery
    
    I'd also recommend skipping the "see ..." bit, and just making the link on "vehicle for [service discovery](...)"


- Joshua Cohen


On April 6, 2016, 3:14 p.m., Tony Dong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45779/
> -----------------------------------------------------------
> 
> (Updated April 6, 2016, 3:14 p.m.)
> 
> 
> Review request for Aurora, Stephan Erb and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Small Documentation fixes and nitpicks.
> 
> 
> Diffs
> -----
> 
>   docs/additional-resources/tools.md 354ccf07b5d457aff387cfa7cc775fea79b3a387 
>   docs/development/client.md 7d0c2309983cb2151af2022997f0f7432f4d2d3d 
>   docs/development/committers-guide.md 309a6522ec9e8750c7b13e211eca7517b358a05f 
>   docs/development/scheduler.md a26dfadf2963538c91c04224540312e01c7f70ae 
>   docs/features/services.md 691fa28ad3e9476e4137bc23dbcda58f5e377387 
>   docs/getting-started/overview.md 854f8d7109a1c7d94dfa960f169d796faba95f87 
> 
> Diff: https://reviews.apache.org/r/45779/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tony Dong
> 
>


Re: Review Request 45779: Small Documentation fixes and nitpicks.

Posted by Tony Dong <to...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45779/
-----------------------------------------------------------

(Updated April 6, 2016, 3:14 p.m.)


Review request for Aurora, Stephan Erb and Bill Farner.


Repository: aurora


Description
-------

Small Documentation fixes and nitpicks.


Diffs (updated)
-----

  docs/additional-resources/tools.md 354ccf07b5d457aff387cfa7cc775fea79b3a387 
  docs/development/client.md 7d0c2309983cb2151af2022997f0f7432f4d2d3d 
  docs/development/committers-guide.md 309a6522ec9e8750c7b13e211eca7517b358a05f 
  docs/development/scheduler.md a26dfadf2963538c91c04224540312e01c7f70ae 
  docs/features/services.md 691fa28ad3e9476e4137bc23dbcda58f5e377387 
  docs/getting-started/overview.md 854f8d7109a1c7d94dfa960f169d796faba95f87 

Diff: https://reviews.apache.org/r/45779/diff/


Testing
-------


Thanks,

Tony Dong