You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2020/03/02 02:34:22 UTC
[GitHub] [incubator-livy] marblejenka opened a new pull request #283: Add
description of POST /batches
marblejenka opened a new pull request #283: Add description of POST /batches
URL: https://github.com/apache/incubator-livy/pull/283
## What changes were proposed in this pull request?
Just added a description of POST /batches in the api-doc.
## How was this patch tested?
Since the change is quite small, I didn't test the patch. If I have an instruction, I will follow it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-livy] codecov-io edited a comment on issue #283: Add
description of POST /batches
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #283: Add description of POST /batches
URL: https://github.com/apache/incubator-livy/pull/283#issuecomment-593199124
# [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/283?src=pr&el=h1) Report
> Merging [#283](https://codecov.io/gh/apache/incubator-livy/pull/283?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/3a2685643670c1cd1530feb7a54516b01784e781?src=pr&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-livy/pull/283?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #283 +/- ##
============================================
+ Coverage 68.2% 68.26% +0.05%
Complexity 965 965
============================================
Files 104 104
Lines 5951 5952 +1
Branches 900 900
============================================
+ Hits 4059 4063 +4
+ Misses 1314 1309 -5
- Partials 578 580 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/283?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...cala/org/apache/livy/scalaapi/ScalaJobHandle.scala](https://codecov.io/gh/apache/incubator-livy/pull/283/diff?src=pr&el=tree#diff-c2NhbGEtYXBpL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zY2FsYWFwaS9TY2FsYUpvYkhhbmRsZS5zY2FsYQ==) | `52.94% <0%> (-2.95%)` | `7% <0%> (ø)` | |
| [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/283/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `80.83% <0%> (ø)` | `45% <0%> (-1%)` | :arrow_down: |
| [...va/org/apache/livy/client/http/LivyConnection.java](https://codecov.io/gh/apache/incubator-livy/pull/283/diff?src=pr&el=tree#diff-Y2xpZW50LWh0dHAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2xpdnkvY2xpZW50L2h0dHAvTGl2eUNvbm5lY3Rpb24uamF2YQ==) | `82.27% <0%> (+0.22%)` | `15% <0%> (ø)` | :arrow_down: |
| [...main/scala/org/apache/livy/server/LivyServer.scala](https://codecov.io/gh/apache/incubator-livy/pull/283/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvTGl2eVNlcnZlci5zY2FsYQ==) | `33.48% <0%> (+0.44%)` | `11% <0%> (ø)` | :arrow_down: |
| [...ain/scala/org/apache/livy/utils/SparkYarnApp.scala](https://codecov.io/gh/apache/incubator-livy/pull/283/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS91dGlscy9TcGFya1lhcm5BcHAuc2NhbGE=) | `73.75% <0%> (+1.87%)` | `40% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/283?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/283?src=pr&el=footer). Last update [3a26856...a6d8aab](https://codecov.io/gh/apache/incubator-livy/pull/283?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-livy] codecov-io commented on issue #283: Add
description of POST /batches
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #283: Add description of POST /batches
URL: https://github.com/apache/incubator-livy/pull/283#issuecomment-593199124
# [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/283?src=pr&el=h1) Report
> Merging [#283](https://codecov.io/gh/apache/incubator-livy/pull/283?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/3a2685643670c1cd1530feb7a54516b01784e781?src=pr&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-livy/pull/283?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #283 +/- ##
============================================
+ Coverage 68.2% 68.26% +0.05%
Complexity 965 965
============================================
Files 104 104
Lines 5951 5952 +1
Branches 900 900
============================================
+ Hits 4059 4063 +4
+ Misses 1314 1309 -5
- Partials 578 580 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/283?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...cala/org/apache/livy/scalaapi/ScalaJobHandle.scala](https://codecov.io/gh/apache/incubator-livy/pull/283/diff?src=pr&el=tree#diff-c2NhbGEtYXBpL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zY2FsYWFwaS9TY2FsYUpvYkhhbmRsZS5zY2FsYQ==) | `52.94% <0%> (-2.95%)` | `7% <0%> (ø)` | |
| [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/283/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `80.83% <0%> (ø)` | `45% <0%> (-1%)` | :arrow_down: |
| [...va/org/apache/livy/client/http/LivyConnection.java](https://codecov.io/gh/apache/incubator-livy/pull/283/diff?src=pr&el=tree#diff-Y2xpZW50LWh0dHAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2xpdnkvY2xpZW50L2h0dHAvTGl2eUNvbm5lY3Rpb24uamF2YQ==) | `82.27% <0%> (+0.22%)` | `15% <0%> (ø)` | :arrow_down: |
| [...main/scala/org/apache/livy/server/LivyServer.scala](https://codecov.io/gh/apache/incubator-livy/pull/283/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvTGl2eVNlcnZlci5zY2FsYQ==) | `33.48% <0%> (+0.44%)` | `11% <0%> (ø)` | :arrow_down: |
| [...ain/scala/org/apache/livy/utils/SparkYarnApp.scala](https://codecov.io/gh/apache/incubator-livy/pull/283/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS91dGlscy9TcGFya1lhcm5BcHAuc2NhbGE=) | `73.75% <0%> (+1.87%)` | `40% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/283?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/283?src=pr&el=footer). Last update [3a26856...a6d8aab](https://codecov.io/gh/apache/incubator-livy/pull/283?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-livy] jerryshao closed pull request #283: [MINOR] Add
description of POST /batches
Posted by GitBox <gi...@apache.org>.
jerryshao closed pull request #283: [MINOR] Add description of POST /batches
URL: https://github.com/apache/incubator-livy/pull/283
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-livy] jerryshao commented on issue #283: [MINOR] Add
description of POST /batches
Posted by GitBox <gi...@apache.org>.
jerryshao commented on issue #283: [MINOR] Add description of POST /batches
URL: https://github.com/apache/incubator-livy/pull/283#issuecomment-604244641
Thanks for the fix, merging to master branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services