You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by GitBox <gi...@apache.org> on 2021/12/29 00:12:38 UTC
[GitHub] [cxf] reta opened a new pull request #889: CXF-8635: Fix org.apache.cxf.jaxrs.client.logging.RESTLoggingTest.testSlf4
reta opened a new pull request #889:
URL: https://github.com/apache/cxf/pull/889
The regression introduced by [CXF-8633](https://issues.apache.org/jira/browse/CXF-8633) causes intermittent tests failures wirh `ConcurrentModificationException`:
```
Caused by: java.util.ConcurrentModificationException
at java.base/java.util.HashMap$HashIterator.nextNode(HashMap.java:1511)
at java.base/java.util.HashMap$EntryIterator.next(HashMap.java:1544)
at java.base/java.util.HashMap$EntryIterator.next(HashMap.java:1542)
at java.base/java.util.HashMap.putMapEntries(HashMap.java:508)
at java.base/java.util.HashMap.putAll(HashMap.java:781)
at org.apache.cxf.message.MessageImpl.calcContextCache(MessageImpl.java:216)
at org.apache.cxf.message.MessageImpl.getContextualProperty(MessageImpl.java:179)
at org.apache.cxf.message.MessageUtils.getContextualProperty(MessageUtils.java:176)
at org.apache.cxf.jaxrs.client.AbstractClient.setResponseBuilder(AbstractClient.java:443)
at org.apache.cxf.jaxrs.client.WebClient.handleResponse(WebClient.java:1169)
... 35 more
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta merged pull request #889: CXF-8635: Fix org.apache.cxf.jaxrs.client.logging.RESTLoggingTest.testSlf4
Posted by GitBox <gi...@apache.org>.
reta merged pull request #889:
URL: https://github.com/apache/cxf/pull/889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta commented on a change in pull request #889: CXF-8635: Fix org.apache.cxf.jaxrs.client.logging.RESTLoggingTest.testSlf4
Posted by GitBox <gi...@apache.org>.
reta commented on a change in pull request #889:
URL: https://github.com/apache/cxf/pull/889#discussion_r776109741
##########
File path: rt/rs/client/src/main/java/org/apache/cxf/jaxrs/client/AbstractClient.java
##########
@@ -440,8 +440,7 @@ protected ResponseBuilder setResponseBuilder(Message outMessage, Exchange exchan
return currentResponseBuilder;
}
- String reasonPhrase = (String)MessageUtils.getContextualProperty(
- responseMessage, HTTPConduit.HTTP_RESPONSE_MESSAGE, null);
+ final String reasonPhrase = (String)responseMessage.get(HTTPConduit.HTTP_RESPONSE_MESSAGE);
Review comment:
@ffang if you could take a look please, it seems like we should fetch the `HTTPConduit.HTTP_RESPONSE_MESSAGE` from the message itself, not the contextual property, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org