[jira] [Commented] (SPARK-25123) SimpleExprValue may cause the loss of a reference

["Apache Spark (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-25123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16580868#comment-16580868 ] 

Apache Spark commented on SPARK-25123:
--------------------------------------

User 'mgaido91' has created a pull request for this issue:
https://github.com/apache/spark/pull/22111

> SimpleExprValue may cause the loss of a reference
> -------------------------------------------------
>
>                 Key: SPARK-25123
>                 URL: https://issues.apache.org/jira/browse/SPARK-25123
>             Project: Spark
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 2.4.0
>            Reporter: Marco Gaido
>            Priority: Major
>
> While introducing the new JavaCode abstraction in order to enable tracking references and allowing transformations, we added 3 types of expression values. They are global variables, local variables and simple expressions.
> While checking whether we could use this new abstraction for fixing an issue reported in another JIRA, I just realized that SimpleExprValue contains a string with the generated code, but this can actually contain other variables. Since the value is carried in SimpleExprValue is a string, though, we were loosing track of the variable reference.
> So this JIRA is for using a Block in order to represent the java code carried by SimpleExprValue, so that we don't loose references.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org