[GitHub] [incubator-eventmesh] ruanwenjun commented on a diff in pull request #944: [Enhancement] code optimize

[GitBox <gi...@apache.org>]

ruanwenjun commented on code in PR #944:
URL: https://github.com/apache/incubator-eventmesh/pull/944#discussion_r902742948


##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/acl/Acl.java:
##########
@@ -87,8 +87,8 @@ public static void doAclCheckInHttpSend(String remoteAddr, String user, String p
     }
 
     public static void doAclCheckInHttpSend(String remoteAddr, String user, String pass, String subsystem, String topic,
-                                            String requestURI) throws AclException {
-        aclService.doAclCheckInSend(buildHttpAclProperties(remoteAddr, user, pass, subsystem, topic, requestURI));
+                                            String requestUri) throws AclException {
+        aclService.doAclCheckInSend(buildHttpAclProperties(remoteAddr, user, pass, subsystem, topic, requestUri));

Review Comment:
   Please revert this change, it's better to use URI here rather than Uri, since URI is the abbreviation for `Uniform Resource Identifier`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org