You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/13 06:09:11 UTC

[GitHub] [arrow] cyb70289 commented on a diff in pull request #13583: ARROW-16807: [C++][R] count distinct incorrectly merges state

cyb70289 commented on code in PR #13583:
URL: https://github.com/apache/arrow/pull/13583#discussion_r919682027


##########
cpp/src/arrow/util/hashing.h:
##########
@@ -428,6 +428,22 @@ class ScalarMemoTable : public MemoTable {
         value, [](int32_t i) {}, [](int32_t i) {}, out_memo_index);
   }
 
+  Status MaybeInsert(const Scalar& value) {

Review Comment:
   Looks `GetOrInsert` can do the job?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org