[GitHub] [apisix] soulbird commented on a diff in pull request #8421: feat: Support store secrets in secrets manager for auth plugin via kms components

[GitBox <gi...@apache.org>]

soulbird commented on code in PR #8421:
URL: https://github.com/apache/apisix/pull/8421#discussion_r1035656526


##########
apisix/kms.lua:
##########
@@ -0,0 +1,182 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements.  See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License.  You may obtain a copy of the License at
+--
+--     http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local require   = require
+local core      = require("apisix.core")
+local string    = require("apisix.core.string")
+
+local find      = string.find
+local sub       = string.sub
+local upper     = string.upper
+local type      = type
+local pcall     = pcall
+local ipairs    = ipairs
+local error     = error
+
+local _M = {
+    version = 0.1,
+}
+
+
+local KMS_PREFIX = "$KMS://"
+local kmss
+
+local function check_kms(conf)
+    local idx = find(conf.id or "", "/")
+    if not idx then
+        return false, "no kms id"
+    end
+    local service = sub(conf.id, 1, idx - 1)
+
+    local ok = pcall(require, "apisix.kms." .. service)
+    if not ok then
+        return false, "kms service not exits, service: " .. service
+    end
+
+    return core.schema.check(core.schema["kms_" .. service], conf)
+end
+
+
+local lrucache = core.lrucache.new({
+    ttl = 300, count = 512
+})
+
+local function create_kms_kvs(values)
+    local kms_services = {}
+
+    for _, v in ipairs(values) do
+        local path = v.value.id
+        local idx = find(path, "/")
+        if not idx then
+            core.log.error("no kms id")
+            return

Review Comment:
   It seems unnecessary to return `nil`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org