You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by "membphis (via GitHub)" <gi...@apache.org> on 2026/03/02 09:09:03 UTC

Re: [PR] feat: added max/resp_body_bytes attr to logger plugins [apisix]

membphis commented on code in PR #13034:
URL: https://github.com/apache/apisix/pull/13034#discussion_r2871283167


##########
apisix/plugins/clickhouse-logger.lua:
##########
@@ -174,6 +177,32 @@ local function send_http_data(conf, log_message)
 end
 
 
+function _M.access(conf, ctx)

Review Comment:
   can we try to reuse those duplicated code?
   
   <img width="728" height="605" alt="Image" src="https://github.com/user-attachments/assets/d2c6dc88-6564-413a-babd-fbf75ebab42f" />



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org