You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Anthony Hsu <ah...@linkedin.com> on 2016/03/26 03:03:17 UTC
Review Request 45348: HIVE-13363: Add hive.metastore.token.signature
property to HiveConf
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45348/
-----------------------------------------------------------
Review request for hive, Carl Steinbach and Ratandeep Ratti.
Bugs: HIVE-13363
https://issues.apache.org/jira/browse/HIVE-13363
Repository: hive-git
Description
-------
No logic changes, just added METASTORE_TOKEN_SIGNATURE property to HiveConf and replaced all instances of `hive.metastore.token.signature` with a references to `HiveConf.ConfVars.METASTORE_TOKEN_SIGNATURE`.
Diffs
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b8870f2ef78884f23e65d9432415e49d89f8ee35
hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HCatUtil.java 3ee30edef50940b4d9da21230177d6fb2a796819
hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/SecureProxySupport.java 13f3c9bd5e523e770dd8ccfd75a442bbbf93b680
itests/hive-unit-hadoop2/src/test/java/org/apache/hadoop/hive/thrift/TestHadoopAuthBridge23.java d07162bd46f8bea88d8c856552a2b4a2d83caf8d
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java cdd12aba9fb4284bbb9989d7fcbe3c591ef17d98
service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java 025b0b810b040ba6ea72b900ccd0802e207033a8
Diff: https://reviews.apache.org/r/45348/diff/
Testing
-------
Ran `grep -r hive.metastore.token.signature --include=*.java *` and saw that the only occurrences of this string are in HiveConf.java and a comment in Security.java.
Thanks,
Anthony Hsu
Re: Review Request 45348: HIVE-13363: Add
hive.metastore.token.signature property to HiveConf
Posted by Ratandeep Ratti <rd...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45348/#review131711
-----------------------------------------------------------
Ship it!
Looks good to me!
- Ratandeep Ratti
On May 4, 2016, 1:30 a.m., Anthony Hsu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45348/
> -----------------------------------------------------------
>
> (Updated May 4, 2016, 1:30 a.m.)
>
>
> Review request for hive, Carl Steinbach and Ratandeep Ratti.
>
>
> Bugs: HIVE-13363
> https://issues.apache.org/jira/browse/HIVE-13363
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> No logic changes, just added METASTORE_TOKEN_SIGNATURE property to HiveConf and replaced all instances of `hive.metastore.token.signature` with a references to `HiveConf.ConfVars.METASTORE_TOKEN_SIGNATURE`.
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 06a6906ef1f5e0b7d941c042c74d257089f46f96
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HCatUtil.java 3ee30edef50940b4d9da21230177d6fb2a796819
> hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/SecureProxySupport.java 13f3c9bd5e523e770dd8ccfd75a442bbbf93b680
> itests/hive-unit-hadoop2/src/test/java/org/apache/hadoop/hive/thrift/TestHadoopAuthBridge23.java d07162bd46f8bea88d8c856552a2b4a2d83caf8d
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 7d37d0706d5f0269b89c4c6486adecf4bb3d85b8
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java 025b0b810b040ba6ea72b900ccd0802e207033a8
>
> Diff: https://reviews.apache.org/r/45348/diff/
>
>
> Testing
> -------
>
> Ran `grep -r hive.metastore.token.signature --include=*.java *` and saw that the only occurrences of this string are in HiveConf.java and a comment in Security.java.
>
>
> Thanks,
>
> Anthony Hsu
>
>
Re: Review Request 45348: HIVE-13363: Add
hive.metastore.token.signature property to HiveConf
Posted by Anthony Hsu <ah...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45348/
-----------------------------------------------------------
(Updated \u4e94\u6708 4, 2016, 1:30 a.m.)
Review request for hive, Carl Steinbach and Ratandeep Ratti.
Changes
-------
Fixed bug in original revision that caused build to fail.
Bugs: HIVE-13363
https://issues.apache.org/jira/browse/HIVE-13363
Repository: hive-git
Description
-------
No logic changes, just added METASTORE_TOKEN_SIGNATURE property to HiveConf and replaced all instances of `hive.metastore.token.signature` with a references to `HiveConf.ConfVars.METASTORE_TOKEN_SIGNATURE`.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 06a6906ef1f5e0b7d941c042c74d257089f46f96
hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HCatUtil.java 3ee30edef50940b4d9da21230177d6fb2a796819
hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/SecureProxySupport.java 13f3c9bd5e523e770dd8ccfd75a442bbbf93b680
itests/hive-unit-hadoop2/src/test/java/org/apache/hadoop/hive/thrift/TestHadoopAuthBridge23.java d07162bd46f8bea88d8c856552a2b4a2d83caf8d
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 7d37d0706d5f0269b89c4c6486adecf4bb3d85b8
service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java 025b0b810b040ba6ea72b900ccd0802e207033a8
Diff: https://reviews.apache.org/r/45348/diff/
Testing
-------
Ran `grep -r hive.metastore.token.signature --include=*.java *` and saw that the only occurrences of this string are in HiveConf.java and a comment in Security.java.
Thanks,
Anthony Hsu