[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed
URL: https://github.com/apache/cloudstack/pull/4002#discussion_r403890338
 
 

 ##########
 File path: engine/schema/src/main/java/com/cloud/capacity/dao/CapacityDaoImpl.java
 ##########
 @@ -903,20 +903,28 @@ public boolean removeBy(Short capacityType, Long zoneId, Long podId, Long cluste
     }
 
     @Override
-    public List<Long> orderHostsByFreeCapacity(Long clusterId, short capacityTypeForOrdering){
+    public List<Long> orderHostsByFreeCapacity(Long zoneId, Long clusterId, short capacityTypeForOrdering){
 
 Review comment:
   @weizhouapache wouldn't a cluster imply a zone? we wouldn't have to pass a zone if we already know the cluster.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services