[GitHub] [skywalking-banyandb] lujiajing1126 commented on pull request #239: Unify TagFilter for Streaming scenario

[GitBox <gi...@apache.org>]

lujiajing1126 commented on PR #239:
URL: https://github.com/apache/skywalking-banyandb/pull/239#issuecomment-1383046938

   I've reverted changes made to the `BuildSchema()` in the `logical/measure` package, but extracted the underlying `TagSpecRegistry` to allow simply using the fine-grained component. This helps overcome the cyclic import issue without breaking the current design.
   
   Further, I've polished the write part by sharing the measure write method among different cases,
   
    - write **real** measure entities,
    - write **virtual** measure entities, i.e. `FlowRecord` generated by `TopNAggregation`, by transforming to a `DataPointForWrite` entity.
   
   The latter would help further optimization, e.g. fully separate `topN` to another package. But this required much work to be done, for example, the current `Repository` is high coupled with a so-called `ResourceSupplier` which is unexpected in the original design.
   
   So I think this PR is sufficient to resolve the current issue. We could stop here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org