You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/02/25 15:01:20 UTC

[GitHub] [activemq-artemis] gemmellr commented on pull request #3470: ARTEMIS-3106 - Support for SASL-SCRAM

gemmellr commented on pull request #3470:
URL: https://github.com/apache/activemq-artemis/pull/3470#issuecomment-785966319


   I'd expect to see testing for auth code like this, especially unit tests but likely an actual systest also. It doesnt seem like there is any (though obviously there is an example, so somewhat counts if it were run)
   
   Perhaps some unit testing inspiration could be taken from [another broker](https://github.com/apache/qpid-broker-j/blob/8.0.4/broker-core/src/test/java/org/apache/qpid/server/security/auth/sasl/scram/ScramNegotiatorTest.java). Its impl might also have allowed for direct lifting without any licensing and attribution consideration at all, already being licensed to the foundation.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org