You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/08 18:16:26 UTC

[GitHub] [superset] AAfghahi commented on a change in pull request #13008: Fix: Disabled state button transition time

AAfghahi commented on a change in pull request #13008:
URL: https://github.com/apache/superset/pull/13008#discussion_r572264786



##########
File path: superset-frontend/src/SqlLab/components/RunQueryActionButton.tsx
##########
@@ -91,25 +91,32 @@ const RunQueryActionButton = ({
     ? (DropdownButton as React.FC)
     : Button;
 
+  const isDisabled = !sql.trim();

Review comment:
       Thank you! Though this was actually Elizabeth's suggestion. So can't take all the credit. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org