You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jasoncl <gi...@git.apache.org> on 2016/01/12 01:23:59 UTC
[GitHub] spark pull request: [Spark-12655] [GraphX] GraphX does not unpersi...
GitHub user jasoncl opened a pull request:
https://github.com/apache/spark/pull/10713
[Spark-12655] [GraphX] GraphX does not unpersist RDDs
Some VertexRDD and EdgeRDD are created during the intermediate step of g.connectedComponents() but unnecessarily left cached after the method is done. The fix is to unpersist these RDDs once they are no longer in use.
A test case is added to confirm the fix for the reported bug.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jasoncl/spark SPARK-12655
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/10713.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10713
----
commit 976d4c74d75150b60cc0f97a5c03bd050faab6f0
Author: Jason Lee <cj...@us.ibm.com>
Date: 2016-01-11T23:57:06Z
Added unpersist graph RDD test case
commit 0f78c0e22e99727f461e9c1c4e62f2d1cdf31ddb
Author: Jason Lee <cj...@us.ibm.com>
Date: 2016-01-12T00:03:37Z
Added unpersist in ConnectedComponents.scala and Pregel.scala. Remove println from test case
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-12655] [GraphX] GraphX does not unpersi...
Posted by apivovarov <gi...@git.apache.org>.
Github user apivovarov commented on a diff in the pull request:
https://github.com/apache/spark/pull/10713#discussion_r49402039
--- Diff: graphx/src/test/scala/org/apache/spark/graphx/GraphSuite.scala ---
@@ -428,4 +428,20 @@ class GraphSuite extends SparkFunSuite with LocalSparkContext {
}
}
+ test("unpersist graph RDD") {
+ withSpark { sc =>
+ val vert = sc.parallelize(List((1L, "a"), (2L, "b"), (3L, "c")), 1)
+ val edges = sc.parallelize(List(Edge[Long](1L, 2L), Edge[Long](1L, 3L)), 1)
+ val g0 = Graph(vert, edges)
+ val g = g0.partitionBy(PartitionStrategy.EdgePartition2D, 2)
+ val cc = g.connectedComponents()
+ assert(sc.persistentRdds.isEmpty === false)
+ cc.unpersist()
+ g.unpersist()
+ g0.unpersist()
+ vert.unpersist()
+ edges.unpersist()
+ assert(sc.persistentRdds.isEmpty === true)
--- End diff --
assert(sc.getPersistentRDDs.isEmpty)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-12655] [GraphX] GraphX does not unpersi...
Posted by apivovarov <gi...@git.apache.org>.
Github user apivovarov commented on a diff in the pull request:
https://github.com/apache/spark/pull/10713#discussion_r49402012
--- Diff: graphx/src/test/scala/org/apache/spark/graphx/GraphSuite.scala ---
@@ -428,4 +428,20 @@ class GraphSuite extends SparkFunSuite with LocalSparkContext {
}
}
+ test("unpersist graph RDD") {
+ withSpark { sc =>
+ val vert = sc.parallelize(List((1L, "a"), (2L, "b"), (3L, "c")), 1)
+ val edges = sc.parallelize(List(Edge[Long](1L, 2L), Edge[Long](1L, 3L)), 1)
+ val g0 = Graph(vert, edges)
+ val g = g0.partitionBy(PartitionStrategy.EdgePartition2D, 2)
+ val cc = g.connectedComponents()
+ assert(sc.persistentRdds.isEmpty === false)
--- End diff --
better to use
```
assert(sc.getPersistentRDDs.nonEmpty)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-12655] [GraphX] GraphX does not unpersi...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10713#issuecomment-171944544
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-12655] [GraphX] GraphX does not unpersi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10713#issuecomment-170878837
**[Test build #2373 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2373/consoleFull)** for PR 10713 at commit [`0f78c0e`](https://github.com/apache/spark/commit/0f78c0e22e99727f461e9c1c4e62f2d1cdf31ddb).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-12655] [GraphX] GraphX does not unpersi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10713#issuecomment-170741952
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-12655] [GraphX] GraphX does not unpersi...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10713#issuecomment-170877285
@jasoncl I agree with this change, though I think this ends up returning RDDs that depend on other RDDs which you then unpersist before use. I agree with the comment on test style.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-12655] [GraphX] GraphX does not unpersi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10713
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-12655] [GraphX] GraphX does not unpersi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10713#issuecomment-170882902
**[Test build #2373 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2373/consoleFull)** for PR 10713 at commit [`0f78c0e`](https://github.com/apache/spark/commit/0f78c0e22e99727f461e9c1c4e62f2d1cdf31ddb).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org