You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2013/10/03 18:21:23 UTC

[1/2] git commit: Polished

Updated Branches:
  refs/heads/camel-2.12.x b0c7920b7 -> 110da9515
  refs/heads/master a27ca6c8e -> a4b7ab2a3


Polished


Project: http://git-wip-us.apache.org/repos/asf/camel/repo
Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/a4b7ab2a
Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/a4b7ab2a
Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/a4b7ab2a

Branch: refs/heads/master
Commit: a4b7ab2a3b763fd8be895ed15ab68775a762d420
Parents: a27ca6c
Author: Claus Ibsen <da...@apache.org>
Authored: Thu Oct 3 18:19:30 2013 +0200
Committer: Claus Ibsen <da...@apache.org>
Committed: Thu Oct 3 18:19:30 2013 +0200

----------------------------------------------------------------------
 .../component/jms/reply/TemporaryQueueReplyManager.java      | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/camel/blob/a4b7ab2a/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/TemporaryQueueReplyManager.java
----------------------------------------------------------------------
diff --git a/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/TemporaryQueueReplyManager.java b/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/TemporaryQueueReplyManager.java
index 8f9084e..a5e8798 100644
--- a/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/TemporaryQueueReplyManager.java
+++ b/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/TemporaryQueueReplyManager.java
@@ -196,7 +196,7 @@ public class TemporaryQueueReplyManager extends ReplyManagerSupport {
 
     private final class TemporaryReplyQueueDestinationResolver implements DestinationResolver {
         private TemporaryQueue queue;
-        private AtomicBoolean refreshWanted = new AtomicBoolean(false);
+        private final AtomicBoolean refreshWanted = new AtomicBoolean(false);
 
         public Destination resolveDestinationName(Session session, String destinationName, boolean pubSubDomain) throws JMSException {
             // use a temporary queue to gather the reply message
@@ -204,7 +204,9 @@ public class TemporaryQueueReplyManager extends ReplyManagerSupport {
                 if (queue == null || refreshWanted.compareAndSet(true, false)) {
                     queue = session.createTemporaryQueue();
                     setReplyTo(queue);
-                    log.debug("Refreshed Temporary ReplyTo Queue. New queue: " + queue.getQueueName());
+                    if (log.isDebugEnabled()) {
+                        log.debug("Refreshed Temporary ReplyTo Queue. New queue: {}", queue.getQueueName());
+                    }
                     refreshWanted.notifyAll();
                 }
             }
@@ -218,7 +220,7 @@ public class TemporaryQueueReplyManager extends ReplyManagerSupport {
         public void destinationReady() throws InterruptedException {
             if (refreshWanted.get()) {
                 synchronized (refreshWanted) {
-                    log.debug("Waiting for new Temp ReplyTo destination to be assigned to continue");
+                    log.debug("Waiting for new Temporary ReplyTo queue to be assigned before we can continue");
                     refreshWanted.wait();
                 }
             }


[2/2] git commit: Polished

Posted by da...@apache.org.
Polished


Project: http://git-wip-us.apache.org/repos/asf/camel/repo
Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/110da951
Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/110da951
Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/110da951

Branch: refs/heads/camel-2.12.x
Commit: 110da951502922cebfe49909c4752463ef0c5961
Parents: b0c7920
Author: Claus Ibsen <da...@apache.org>
Authored: Thu Oct 3 18:19:30 2013 +0200
Committer: Claus Ibsen <da...@apache.org>
Committed: Thu Oct 3 18:21:06 2013 +0200

----------------------------------------------------------------------
 .../component/jms/reply/TemporaryQueueReplyManager.java      | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/camel/blob/110da951/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/TemporaryQueueReplyManager.java
----------------------------------------------------------------------
diff --git a/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/TemporaryQueueReplyManager.java b/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/TemporaryQueueReplyManager.java
index 8f9084e..a5e8798 100644
--- a/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/TemporaryQueueReplyManager.java
+++ b/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/TemporaryQueueReplyManager.java
@@ -196,7 +196,7 @@ public class TemporaryQueueReplyManager extends ReplyManagerSupport {
 
     private final class TemporaryReplyQueueDestinationResolver implements DestinationResolver {
         private TemporaryQueue queue;
-        private AtomicBoolean refreshWanted = new AtomicBoolean(false);
+        private final AtomicBoolean refreshWanted = new AtomicBoolean(false);
 
         public Destination resolveDestinationName(Session session, String destinationName, boolean pubSubDomain) throws JMSException {
             // use a temporary queue to gather the reply message
@@ -204,7 +204,9 @@ public class TemporaryQueueReplyManager extends ReplyManagerSupport {
                 if (queue == null || refreshWanted.compareAndSet(true, false)) {
                     queue = session.createTemporaryQueue();
                     setReplyTo(queue);
-                    log.debug("Refreshed Temporary ReplyTo Queue. New queue: " + queue.getQueueName());
+                    if (log.isDebugEnabled()) {
+                        log.debug("Refreshed Temporary ReplyTo Queue. New queue: {}", queue.getQueueName());
+                    }
                     refreshWanted.notifyAll();
                 }
             }
@@ -218,7 +220,7 @@ public class TemporaryQueueReplyManager extends ReplyManagerSupport {
         public void destinationReady() throws InterruptedException {
             if (refreshWanted.get()) {
                 synchronized (refreshWanted) {
-                    log.debug("Waiting for new Temp ReplyTo destination to be assigned to continue");
+                    log.debug("Waiting for new Temporary ReplyTo queue to be assigned before we can continue");
                     refreshWanted.wait();
                 }
             }