You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by upthewaterspout <gi...@git.apache.org> on 2017/03/09 01:34:26 UTC

[GitHub] geode pull request #421: GEODE-2595: Change LuceneService.createIndex to use...

GitHub user upthewaterspout opened a pull request:

    https://github.com/apache/geode/pull/421

    GEODE-2595: Change LuceneService.createIndex to use a factory

    Changing LuceneService.createIndex to createIndexFactory and
    using a factory pattern to create the index.
    
    This allows us to introduce new options to the index create without
    breaking backwards compatibility in the future.
    
    @ladyVader @nabarunnag @boglesby

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/upthewaterspout/incubator-geode feature/GEODE-2595

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/421.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #421
    
----
commit f912be793ff7a73855df903148d4b74dfdc415b9
Author: Dan Smith <up...@apache.org>
Date:   2017-03-09T01:15:44Z

    GEODE-2595: Change LuceneService.createIndex to use a factory
    
    Changing LuceneService.createIndex to createIndexFactory and
    using a factory pattern to create the index.
    
    This allows us to introduce new options to the index create without
    breaking backwards compatibility in the future.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #421: GEODE-2595: Change LuceneService.createIndex to use a fact...

Posted by metatype <gi...@git.apache.org>.
Github user metatype commented on the issue:

    https://github.com/apache/geode/pull/421
  
    API changes look good to me.  There's a compile error in a test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #421: GEODE-2595: Change LuceneService.createIndex to use...

Posted by gesterzhou <gi...@git.apache.org>.
Github user gesterzhou commented on a diff in the pull request:

    https://github.com/apache/geode/pull/421#discussion_r105441883
  
    --- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneService.java ---
    @@ -37,15 +36,17 @@
      * </p>
      * <p>
      * Lucene indexes can be created using gfsh, xml, or the java API. Below is an example of creating a
    - * Lucene index with the java API. The Lucene index created on each member that will host data for
    - * the region.
    + * Lucene index with the java API. The Lucene index should be created on each member that has the
    + * region that is being indexed.
      * </p>
      * 
      * <pre>
      * {
      *   &#64;code
    - *   LuceneIndex index =
    - *       luceneService.createIndex(indexName, regionName, "field1", "field2", "field3");
    +*       luceneService.createCreateIndexFactory()
    --- End diff --
    
    I don't like the name "createCreateIndexFactory". 2 create?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #421: GEODE-2595: Change LuceneService.createIndex to use...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/geode/pull/421


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #421: GEODE-2595: Change LuceneService.createIndex to use a fact...

Posted by upthewaterspout <gi...@git.apache.org>.
Github user upthewaterspout commented on the issue:

    https://github.com/apache/geode/pull/421
  
    Good catch Anthony. I've pushed a fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #421: GEODE-2595: Change LuceneService.createIndex to use a fact...

Posted by upthewaterspout <gi...@git.apache.org>.
Github user upthewaterspout commented on the issue:

    https://github.com/apache/geode/pull/421
  
    Good catch, Gester! I'll fix that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---