You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/01/26 03:33:36 UTC
[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #5299: [BackupAndRestore] Support backup and restore view and external odbc table
EmmyMiao87 opened a new pull request #5299:
URL: https://github.com/apache/incubator-doris/pull/5299
## Proposed changes
1. Support backup and restore view and odbc table. The syntax is the same as the backup and restore table.
2. If the table associated with the view does not exist in the snapshot,
the view can still be backed up successfully, but the TableNotFound exception will be thrown when querying the view.
3. If the odbc table associated with the odbc resource, the odbc resource will be backuped and restored together.
4. If the same view, odbc table and resource already exists in the database, it will compare whether the metadata of snapshot is consistent.
If it is inconsistent, the restoration will fail.
4. This pr also modified the json format of the backup information.
A `new_backup_objects` object is added to the root node to store backup meta-information other than olap table,
such as views and external tables.
```
{
"backup_objects": {},
"new_backup_objects": {
"view": [
{"name": "view1", "id": "10001"}
],
"odbc_table": [
{"name":"xxx", xxx}
]
"odbc_resources": [
{"name": "bj_oracle"}
]
}
}
```
5. This pr changes the serialization and deserialization method of backup information
from manual construction to automatic analysis by Gson tools.
Change-Id: I216469bf2a6484177185d8354dcca2dc19f653f3
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [] Documentation Update (if none of the other choices apply)
- [] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [] I have created an issue on (Fix #5298) and described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
- [x] I have added tests that prove my fix is effective or that my feature works
- [] If these changes need document changes, I have updated the document
- [] Any dependent changes have been merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 merged pull request #5299: [BackupAndRestore] Support backup and restore view and external odbc table
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 merged pull request #5299:
URL: https://github.com/apache/incubator-doris/pull/5299
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #5299: [BackupAndRestore] Support backup and restore view and external odbc table
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #5299:
URL: https://github.com/apache/incubator-doris/pull/5299#discussion_r565254061
##########
File path: fe/fe-core/src/main/java/org/apache/doris/backup/BackupJob.java
##########
@@ -843,6 +930,15 @@ public void readFields(DataInput in) throws IOException {
if (in.readBoolean()) {
localJobInfoFilePath = Text.readString(in);
}
+
+ if (Catalog.getCurrentCatalogJournalVersion() < FeMetaVersion.VERSION_95) {
+ return;
+ }
+ // read properties
+ size = in.readInt();
+ for (int i = 0; i < size; i++) {
+ properties.put(Text.readString(in), Text.readString(in));
Review comment:
better deser key and value line by line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org