You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/11 12:55:40 UTC

[GitHub] [arrow-rs] alamb opened a new issue #1027: `MutableBuffer::typed_data_mut` is not `safe`

alamb opened a new issue #1027:
URL: https://github.com/apache/arrow-rs/issues/1027


   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   As pointed out by @jhorstmann  on #921 at https://github.com/apache/arrow-rs/pull/921#discussion_r760086317, 
   
   `Buffer::typed_data` is marked `unsafe` and it is very similar`MutableBuffer::typed_data_mut` which is not marked as unsafe. 
   
   After some more research on https://github.com/apache/arrow-rs/issues/996, it seems like the most appropriate thing to do is to mark `MutableBuffer::typed_data_mut` so the rust type system can better match the semantics.
   
   **Describe the solution you'd like**
   1. Add `unsafe` from `Buffer::typed_data`
   2. Remove note about bool in docstrings
   
   **Additional context***
   More details on https://github.com/apache/arrow-rs/issues/996


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-rs] alamb closed issue #1027: `MutableBuffer::typed_data_mut` is not `safe`

Posted by GitBox <gi...@apache.org>.
alamb closed issue #1027:
URL: https://github.com/apache/arrow-rs/issues/1027


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org