You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "fallintoplace (via GitHub)" <gi...@apache.org> on 2026/07/29 16:54:00 UTC
[PR] fix(arrow/ipc): stop initial dictionary loading after unexpected message type [arrow-go]
fallintoplace opened a new pull request, #1054:
URL: https://github.com/apache/arrow-go/pull/1054
The IPC stream reader recorded an error when an initial dictionary slot contained another message type, but then continued and tried to decode that message as a dictionary. This could replace the useful protocol error and consume the wrong message.\n\nStop immediately, mark the reader done, and preserve the expected-dictionary error. The regression test builds a dictionary schema followed directly by a record batch.\n\nValidated with ok github.com/apache/arrow-go/v18/arrow/ipc 0.411s [no tests to run] and the full arrow/ipc package tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(arrow/ipc): reject non-dictionary initial messages [arrow-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #1054:
URL: https://github.com/apache/arrow-go/pull/1054#discussion_r3722419917
##########
arrow/ipc/reader.go:
##########
@@ -223,7 +223,9 @@ func (r *Reader) getInitialDicts() bool {
}
if msg.Type() != MessageDictionaryBatch {
+ r.done = true
Review Comment:
do we need to add the `r.done` if we're setting `r.err`? I believe we check `r.done || r.err != nil` right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(arrow/ipc): reject non-dictionary initial messages [arrow-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #1054:
URL: https://github.com/apache/arrow-go/pull/1054
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org