You are viewing a plain text version of this content. The canonical link for it is here.
Posted to muse-dev@ws.apache.org by "Chris Twiner (JIRA)" <ji...@apache.org> on 2007/08/16 20:05:31 UTC
[jira] Created: (MUSE-264) FilterCollections not supported with the
"HACKS" in SimpleNotificationProducer
FilterCollections not supported with the "HACKS" in SimpleNotificationProducer
------------------------------------------------------------------------------
Key: MUSE-264
URL: https://issues.apache.org/jira/browse/MUSE-264
Project: Muse
Issue Type: Bug
Components: WSN NotificationProducer
Affects Versions: 2.2.0
Reporter: Chris Twiner
Assignee: Dan Jemiolo
Fix For: 2.3.0
Any subsciption that is made remotely (e.g. via subscribe method on a proxy) creates a FilterCollection and passes it into the SimpleNotificationProducer subscribe method.
The code in SimpleNotificationProducer should support the subscription of a FilterCollection in both subscribe and in addSubscription (from persisted subscriptions).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: muse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: muse-dev-help@ws.apache.org
[jira] Updated: (MUSE-264) FilterCollections not supported with the
"HACKS" in SimpleNotificationProducer
Posted by "Chris Twiner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MUSE-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Twiner updated MUSE-264:
------------------------------
Attachment: producer.diff
diffed with -uN.
> FilterCollections not supported with the "HACKS" in SimpleNotificationProducer
> ------------------------------------------------------------------------------
>
> Key: MUSE-264
> URL: https://issues.apache.org/jira/browse/MUSE-264
> Project: Muse
> Issue Type: Bug
> Components: WSN NotificationProducer
> Affects Versions: 2.2.0
> Reporter: Chris Twiner
> Assignee: Dan Jemiolo
> Fix For: 2.3.0
>
> Attachments: producer.diff
>
>
> Any subsciption that is made remotely (e.g. via subscribe method on a proxy) creates a FilterCollection and passes it into the SimpleNotificationProducer subscribe method.
> The code in SimpleNotificationProducer should support the subscription of a FilterCollection in both subscribe and in addSubscription (from persisted subscriptions).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: muse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: muse-dev-help@ws.apache.org
[jira] Commented: (MUSE-264) FilterCollections not supported with
the "HACKS" in SimpleNotificationProducer
Posted by "Chris Twiner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MUSE-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520348 ]
Chris Twiner commented on MUSE-264:
-----------------------------------
Note this can lead to NPEs in ProducerPropertiesFilter since the resource isn't set
> FilterCollections not supported with the "HACKS" in SimpleNotificationProducer
> ------------------------------------------------------------------------------
>
> Key: MUSE-264
> URL: https://issues.apache.org/jira/browse/MUSE-264
> Project: Muse
> Issue Type: Bug
> Components: WSN NotificationProducer
> Affects Versions: 2.2.0
> Reporter: Chris Twiner
> Assignee: Dan Jemiolo
> Fix For: 2.3.0
>
> Attachments: producer.diff
>
>
> Any subsciption that is made remotely (e.g. via subscribe method on a proxy) creates a FilterCollection and passes it into the SimpleNotificationProducer subscribe method.
> The code in SimpleNotificationProducer should support the subscription of a FilterCollection in both subscribe and in addSubscription (from persisted subscriptions).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: muse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: muse-dev-help@ws.apache.org
[jira] Issue Comment Edited: (MUSE-264) FilterCollections not
supported with the "HACKS" in SimpleNotificationProducer
Posted by "Chris Twiner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MUSE-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520348 ]
c_twiner edited comment on MUSE-264 at 8/16/07 1:12 PM:
------------------------------------------------------------
Note this can lead to NPEs in ProducerPropertiesFilter since the resource isn't set. I assume that it is not a heavily used feature (I need it for SLA enforcement on metrics etc), if people need a simple workaround for 2.2.0 (just the ProducerPropertiesFilter issue) feel free to email me.
was (Author: c_twiner):
Note this can lead to NPEs in ProducerPropertiesFilter since the resource isn't set
> FilterCollections not supported with the "HACKS" in SimpleNotificationProducer
> ------------------------------------------------------------------------------
>
> Key: MUSE-264
> URL: https://issues.apache.org/jira/browse/MUSE-264
> Project: Muse
> Issue Type: Bug
> Components: WSN NotificationProducer
> Affects Versions: 2.2.0
> Reporter: Chris Twiner
> Assignee: Dan Jemiolo
> Fix For: 2.3.0
>
> Attachments: producer.diff
>
>
> Any subsciption that is made remotely (e.g. via subscribe method on a proxy) creates a FilterCollection and passes it into the SimpleNotificationProducer subscribe method.
> The code in SimpleNotificationProducer should support the subscription of a FilterCollection in both subscribe and in addSubscription (from persisted subscriptions).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: muse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: muse-dev-help@ws.apache.org
[jira] Closed: (MUSE-264) FilterCollections not supported with the
"HACKS" in SimpleNotificationProducer
Posted by "Dan Jemiolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MUSE-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Jemiolo closed MUSE-264.
----------------------------
Resolution: Fixed
Applied Chris' patch with slight change to exception handling.
> FilterCollections not supported with the "HACKS" in SimpleNotificationProducer
> ------------------------------------------------------------------------------
>
> Key: MUSE-264
> URL: https://issues.apache.org/jira/browse/MUSE-264
> Project: Muse
> Issue Type: Bug
> Components: WSN NotificationProducer
> Affects Versions: 2.2.0
> Reporter: Chris Twiner
> Assignee: Dan Jemiolo
> Fix For: 2.3.0
>
> Attachments: producer.diff
>
>
> Any subsciption that is made remotely (e.g. via subscribe method on a proxy) creates a FilterCollection and passes it into the SimpleNotificationProducer subscribe method.
> The code in SimpleNotificationProducer should support the subscription of a FilterCollection in both subscribe and in addSubscription (from persisted subscriptions).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: muse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: muse-dev-help@ws.apache.org
[jira] Issue Comment Edited: (MUSE-264) FilterCollections not
supported with the "HACKS" in SimpleNotificationProducer
Posted by "Chris Twiner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MUSE-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520348 ]
c_twiner edited comment on MUSE-264 at 8/16/07 11:05 PM:
-------------------------------------------------------------
Note this can lead to NPEs in ProducerPropertiesFilter since the resource isn't set. I assume that it is not a heavily used feature (I need it for SLA enforcement on metrics etc), if people need a simple workaround for 2.2.0 (just the ProducerPropertiesFilter issue) feel free to email me.
As a long term solution it may be better to introduce a processProducer(NotificationProducer) function into the Filters. TopicFilter can use it directly, and ProducerProperties can use it to call getWsResource(). That would do away with the instanceofs. This would allow further handling to be pluggable with the FilterFactory handlers rather than new releases or deriving from ProducerPropertiesFilter
was (Author: c_twiner):
Note this can lead to NPEs in ProducerPropertiesFilter since the resource isn't set. I assume that it is not a heavily used feature (I need it for SLA enforcement on metrics etc), if people need a simple workaround for 2.2.0 (just the ProducerPropertiesFilter issue) feel free to email me.
> FilterCollections not supported with the "HACKS" in SimpleNotificationProducer
> ------------------------------------------------------------------------------
>
> Key: MUSE-264
> URL: https://issues.apache.org/jira/browse/MUSE-264
> Project: Muse
> Issue Type: Bug
> Components: WSN NotificationProducer
> Affects Versions: 2.2.0
> Reporter: Chris Twiner
> Assignee: Dan Jemiolo
> Fix For: 2.3.0
>
> Attachments: producer.diff
>
>
> Any subsciption that is made remotely (e.g. via subscribe method on a proxy) creates a FilterCollection and passes it into the SimpleNotificationProducer subscribe method.
> The code in SimpleNotificationProducer should support the subscription of a FilterCollection in both subscribe and in addSubscription (from persisted subscriptions).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: muse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: muse-dev-help@ws.apache.org