You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/01/12 04:21:20 UTC
[GitHub] [dubbo-samples] daimingbao opened a new pull request #252: improve dubbo-samples-scala case
daimingbao opened a new pull request #252:
URL: https://github.com/apache/dubbo-samples/pull/252
update config and improve test case
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] daimingbao closed pull request #252: improve dubbo-samples-scala case
Posted by GitBox <gi...@apache.org>.
daimingbao closed pull request #252:
URL: https://github.com/apache/dubbo-samples/pull/252
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] kylixs commented on a change in pull request #252: improve dubbo-samples-scala case
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #252:
URL: https://github.com/apache/dubbo-samples/pull/252#discussion_r555516150
##########
File path: dubbo-samples-scala/pom.xml
##########
@@ -31,21 +31,9 @@
<target.level>1.8</target.level>
<spring.version>4.3.16.RELEASE</spring.version>
<dubbo.version>2.7.7</dubbo.version>
- <dubbo.rpc.version>2.7.5</dubbo.rpc.version>
- <zookeeper.version>3.4.13</zookeeper.version>
<dubbo.configcenter.zookeeper.version>2.7.4</dubbo.configcenter.zookeeper.version>
Review comment:
dubbo.configcenter.zookeeper.version 这个改成dubbo.version？
##########
File path: dubbo-samples-scala/pom.xml
##########
@@ -232,56 +136,6 @@
<target>${target.level}</target>
</configuration>
</plugin>
- <plugin>
Review comment:
apache-rat-plugin 这个不用删除
##########
File path: dubbo-samples-scala/pom.xml
##########
@@ -301,57 +155,10 @@
</execution>
</executions>
</plugin>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-surefire-plugin</artifactId>
- <version>2.19</version>
- <configuration>
- <useFile>false</useFile>
- <disableXmlReport>true</disableXmlReport>
- </configuration>
- </plugin>
</plugins>
</build>
<profiles>
- <profile>
- <id>checkstyle</id>
Review comment:
checkstyle不用删除
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org